Differential D2493

WIP: refresh collections
ClosedPublic
Actions

Authored by dereckson on Jan 29 2022, 20:24.

Tags

None

Referenced Files

	F3748022: D2493.diff
	Sat, Nov 16, 06:16

	Unknown Object (File)
	Tue, Nov 12, 15:08

	Unknown Object (File)
	Tue, Nov 12, 05:16

	Unknown Object (File)
	Mon, Nov 11, 20:25

	Unknown Object (File)
	Mon, Nov 11, 07:55

	Unknown Object (File)
	Wed, Nov 6, 17:53

	Unknown Object (File)
	Tue, Nov 5, 20:00

	Unknown Object (File)
	Mon, Nov 4, 18:27

Subscribers

None

Details

Reviewers

Commits

rKOTfa1c68f22e5b: Refresh collections

Summary

Create a way to express the intent of an array in the code:
Vector and HashMap classes allow to convey the ideas keys
will be indexes or keys.

Still to do: ArrayAccess, dedup, tests

Test Plan

New tests units suite (still to write)

Diff Detail

Repository

rKOT Keruald OmniTools

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/DateTime/DateStamp.php:66	PHPCS.E.Generic.Files.LineLength.MaxExceeded	Generic.Files.LineLength.MaxExceeded
Error	src/Strings/Multibyte/StringUtilities.php:14	PHPCS.E.Generic.Files.LineLength.MaxExceeded	Generic.Files.LineLength.MaxExceeded
Warning	tests/Collections/VectorTest.php:103	PHPCS.W.Generic.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClass	Generic.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClass

Unit

Tests Passed

Branch

collections

Build Status

Buildable 3910
Build 4161: arc lint + arc unit

Event Timeline

dereckson created this revision.Jan 29 2022, 20:24

dereckson held this revision as a draft.

Harbormaster completed remote builds in B3884: Diff 6282.Jan 29 2022, 20:24

More tests

Harbormaster completed remote builds in B3910: Diff 6319.Feb 9 2022, 22:50

dereckson published this revision for review.Feb 9 2022, 22:52

dereckson accepted this revision.

This revision is now accepted and ready to land.Feb 9 2022, 22:52

This revision was landed with ongoing or failed builds.Feb 9 2022, 22:53

Closed by commit rKOTfa1c68f22e5b: Refresh collections (authored by dereckson). · Explain Why

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKOTfa1c68f22e5b: Refresh collections.

Revision Contents
Changeset List

Path

Size

src/

Collections/

BaseCollection.php

26 lines

17 lines

167 lines

32 lines

TraversableUtilities.php

26 lines

206 lines

DateTime/

4 lines

HTTP/

4 lines

Reflection/

CallableElement.php

75 lines

Strings/

Multibyte/

18 lines

StringUtilities.php

15 lines

tests/

Collections/

ArrayUtilitiesTest.php

24 lines

HashMapTest.php

273 lines

OmniArrayTest.php

TraversableUtilitiesTest.php

68 lines

171 lines

Diff 6319

src/Collections/BaseCollection.php

Loading...

src/Collections/BaseMap.php

Loading...

src/Collections/HashMap.php

Loading...

src/Collections/OmniArray.php

Loading...

src/Collections/SharedBag.php

Loading...

src/Collections/TraversableUtilities.php

Loading...

src/Collections/Vector.php

Loading...

src/DateTime/DateStamp.php

Loading...

src/HTTP/URL.php

Loading...

src/Reflection/CallableElement.php

Loading...

src/Strings/Multibyte/OmniString.php

Loading...

src/Strings/Multibyte/StringUtilities.php

Loading...

tests/Collections/ArrayUtilitiesTest.php

Loading...

tests/Collections/HashMapTest.php

Loading...

tests/Collections/OmniArrayTest.php

Loading...

tests/Collections/TraversableUtilitiesTest.php

Loading...

tests/Collections/VectorTest.php

Loading...