Differential D2536

Simplify maxPropertyLength computation
ClosedPublic
Actions

Authored by DorianWinty on Feb 17 2022, 21:18.

Tags

None

Referenced Files

	F56573867: D2536.id6402.diff
	Sat, Nov 7, 08:08

	F56573857: D2536.id6399.diff
	Sat, Nov 7, 08:08

	F56573850: D2536.id6400.diff
	Sat, Nov 7, 08:08

	F56573847: D2536.id.diff
	Sat, Nov 7, 08:08

	F55996200: D2536.diff
	Mon, Nov 2, 00:47

	F55984235: D2536.id6400.diff
	Sun, Nov 1, 23:01

	F55972868: D2536.id6399.diff
	Sun, Nov 1, 21:13

	F55959641: D2536.id.diff
	Sun, Nov 1, 18:54

Subscribers

None

Details

Reviewers

Commits

rKREPORT3c06786204d0: Simplify maxPropertyLength computation

Summary

maxPropertyLength modify for making more easy

Diff Detail

Repository

rKREPORT Keruald Report

Lint

Lint Passed

Unit

Tests Passed

Branch

mark_update

Build Status

Buildable 3962
Build 4214: arc lint + arc unit

Event Timeline

DorianWinty requested review of this revision.Feb 17 2022, 21:18

DorianWinty created this revision.

Harbormaster completed remote builds in B3962: Diff 6399.Feb 17 2022, 21:18

a

Harbormaster completed remote builds in B3963: Diff 6400.Feb 17 2022, 21:18

DorianWinty added a reviewer: dereckson.Feb 17 2022, 21:19

dereckson added inline comments.Feb 17 2022, 21:22

src/Output/MarkdownOutput.php
34	min() instead of max() if the goal is to get at least 8 characters?

dereckson retitled this revision from modify maxpropertylength to Simplify maxPropertyLength computation.Feb 17 2022, 21:23

DorianWinty added inline comments.Feb 17 2022, 21:28

src/Output/MarkdownOutput.php
34	if i put min() when $propertyMaxLength is more than 8 the number will stay at 8 but if i use max if $propertyMaxLength > 8 then it will be the value of the property

dereckson accepted this revision.Feb 17 2022, 21:45

This revision is now accepted and ready to land.Feb 17 2022, 21:45

Indeed, mea culpa.

Closed by commit rKREPORT3c06786204d0: Simplify maxPropertyLength computation (authored by DorianWinty, committed by dereckson). · Explain WhyFeb 17 2022, 21:47

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKREPORT3c06786204d0: Simplify maxPropertyLength computation.

Revision Contents
Changeset List

Path

Size

src/

Output/

MarkdownOutput.php

4 lines

Diff 6399

src/Output/MarkdownOutput.php

Loading...