Format correctly empty or partial reports.
Details
Details
- Reviewers
dereckson - Commits
- rKREPORT3cd3b60859ba: Handle incomplete reports
Unit tests from D2537 pass.
Diff Detail
Diff Detail
- Repository
- rKREPORT Keruald Report
- Lint
Lint Passed - Unit
Tests Passed - Branch
- complete_tests
- Build Status
Buildable 3969 Build 4221: arc lint + arc unit
Event Timeline
src/Output/HTMLOutput.php | ||
---|---|---|
68 | That's actually the explicit title of the report: yield ["empty", new Report("Void report")]; | |
src/Output/MarkdownOutput.php | ||
16–20 | In Markdown, we don't do print anything before or after the foreach loop content. So this if isn't needed: if there isn't any section, the content of foreach won't be executed. | |
src/Output/XMLOutput.php | ||
26–31 | Same than for Markdown: this loop prints each time a section tag: <section> ... </section> So if we skip the if, it will still work as we don't print anything before or after. | |
tests/Output/XMLOutputTest.php | ||
26 ↗ | (On Diff #6404) | Should be fixed in D2537. |
tests/data/empty.xml | ||
2 ↗ | (On Diff #6404) | Amend D2537 with that one too. |
This comment was removed by DorianWinty.
src/Output/XMLOutput.php | ||
---|---|---|
75 | Aooouuu? Still a harccoded title here. |