Page MenuHomeDevCentral

Handle incomplete reports
ClosedPublic

Authored by DorianWinty on Feb 18 2022, 22:27.
Tags
None
Referenced Files
F3760837: D2538.id6403.diff
Wed, Nov 20, 10:12
F3760832: D2538.id6411.diff
Wed, Nov 20, 10:10
Unknown Object (File)
Mon, Nov 18, 03:17
Unknown Object (File)
Sun, Nov 17, 12:50
Unknown Object (File)
Sun, Nov 17, 12:36
Unknown Object (File)
Sun, Nov 17, 04:23
Unknown Object (File)
Sun, Nov 17, 04:04
Unknown Object (File)
Sat, Nov 16, 01:39
Subscribers
None

Details

Summary

Format correctly empty or partial reports.

Test Plan

Unit tests from D2537 pass.

Diff Detail

Repository
rKREPORT Keruald Report
Lint
Lint Passed
Unit
Tests Passed
Branch
complete_tests
Build Status
Buildable 3970
Build 4222: arc lint + arc unit

Event Timeline

DorianWinty created this revision.
DorianWinty retitled this revision from Test incomplete reports to complete test reports.Feb 18 2022, 22:29
DorianWinty edited reviewers, added: dereckson; removed: DorianWinty.
dereckson requested changes to this revision.Feb 19 2022, 09:16
dereckson added inline comments.
src/Output/HTMLOutput.php
68

That's actually the explicit title of the report:

yield ["empty", new Report("Void report")];
src/Output/MarkdownOutput.php
15–16

In Markdown, we don't do print anything before or after the foreach loop content.

So this if isn't needed: if there isn't any section, the content of foreach won't be executed.

src/Output/XMLOutput.php
25–26

Same than for Markdown: this loop prints each time a section tag:

<section>
...
</section>

So if we skip the if, it will still work as we don't print anything before or after.

tests/Output/XMLOutputTest.php
26

Should be fixed in D2537.

tests/data/empty.xml
2

Amend D2537 with that one too.

This revision now requires changes to proceed.Feb 19 2022, 09:16
DorianWinty marked 3 inline comments as done.

modify with comments

This comment was removed by DorianWinty.
dereckson retitled this revision from complete test reports to Handle incomplete reports.Feb 21 2022, 22:54
dereckson edited the summary of this revision. (Show Details)
dereckson edited the test plan for this revision. (Show Details)
dereckson requested changes to this revision.Feb 21 2022, 22:56
dereckson added inline comments.
src/Output/XMLOutput.php
75

Aooouuu?

Still a harccoded title here.

This revision now requires changes to proceed.Feb 21 2022, 22:56

removing the else statement
because we never pass on the statment and on void case

This revision is now accepted and ready to land.Feb 22 2022, 17:11
This revision was automatically updated to reflect the committed changes.