Paths

Table of Contentst

Handle NULL value
ClosedPublic
Actions

Authored by dereckson on Feb 27 2022, 01:36.

Tags

None

Referenced Files

	F24655377: D2563.id6474.diff
	Tue, Mar 3, 13:14

	F24655369: D2563.id6475.diff
	Tue, Mar 3, 13:14

	Unknown Object (File)
	Sun, Mar 1, 23:39

	Unknown Object (File)
	Sat, Feb 28, 16:36

	Unknown Object (File)
	Sat, Feb 28, 12:19

	Unknown Object (File)
	Fri, Feb 27, 23:14

	Unknown Object (File)
	Thu, Feb 26, 12:53

	Unknown Object (File)
	Tue, Feb 24, 12:20

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rINFRAWWWac3264504858: Handle NULL value

Summary

The dump didn't handle the NULL type.

This created an issue, as a NULL value in JavaScript:

is an object (sic)
doesn't have a constructor property in prototype

Test Plan

runas: {{ bot['runas'] | default('') }}
now renders as runas: NULL.

Diff Detail

Repository

rINFRAWWW Nasqueron infrastructure servers website

Lint

Lint Passed

Unit

No Test Coverage

Branch

main

Build Status

Buildable 4013
Build 4265: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Feb 27 2022, 01:36

dereckson created this revision.

Harbormaster completed remote builds in B4013: Diff 6474.Feb 27 2022, 01:36

dereckson accepted this revision.Feb 27 2022, 01:36

This revision is now accepted and ready to land.Feb 27 2022, 01:36

SCSS rules gives:

That should attract attention it's not an expected value.

Closed by commit rINFRAWWWac3264504858: Handle NULL value (authored by dereckson). · Explain WhyFeb 27 2022, 01:37

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rINFRAWWWac3264504858: Handle NULL value.

Revision Contents
Changeset List

Path

Size

src/

assets/

js/

salt-config.js

4 lines

scss/

components/

_salt-config.scss

6 lines

Diff 6474

View Options

src/assets/js/salt-config.js