Page MenuHomeDevCentral
Differential D2577

Don't shadow variables
ClosedPublic
Actions

Authored by dereckson on Mar 7 2022, 20:14.
Tags
None
Referenced Files
F34184243: D2577.id6510.diff
Fri, Jun 26, 06:00
Unknown Object (File)
Tue, Jun 23, 16:05
Unknown Object (File)
Sun, Jun 21, 15:22
Unknown Object (File)
Sun, Jun 21, 08:11
Unknown Object (File)
Thu, Jun 18, 04:23
Unknown Object (File)
Thu, Jun 18, 04:07
Unknown Object (File)
Mon, Jun 15, 19:32
Unknown Object (File)
Sun, Jun 14, 05:01
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rOPS5a1d179f76e5: Don't shadow variables
Summary

Variables like id and list are built-ins.

A method argument can't share the same name with the procedural code.

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Mar 7 2022, 20:14
dereckson created this revision.
Harbormaster completed remote builds in B4038: Diff 6510.Mar 7 2022, 20:14
dereckson accepted this revision.Mar 7 2022, 20:16
This revision is now accepted and ready to land.Mar 7 2022, 20:16
This revision was landed with ongoing or failed builds.Mar 7 2022, 20:16
Closed by commit rOPS5a1d179f76e5: Don't shadow variables (authored by dereckson). · Explain Why
This revision was automatically updated to reflect the committed changes.
dereckson added a commit: rOPS5a1d179f76e5: Don't shadow variables.

Revision Contents
Changeset List

PathSize
_modules/
4 lines
44 lines
6 lines
roles/
paas-jails/
jails/
2 lines
utils/
4 lines
8 lines
4 lines

Diff 6511

View Options

_modules/jails.py

Loading...
View Options

_modules/opensearch.py

Loading...
View Options

_modules/zr.py

Loading...
View Options

roles/paas-jails/jails/init.sls

Loading...
View Options

utils/dump-py-state.py

Loading...
View Options

utils/generate-webcontent-index.py

Loading...
View Options

utils/next-uid.py

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator