Page MenuHomeDevCentral

GitHubPayloadAnalyzerConfiguration::getDefaultGroup()
ClosedPublic

Authored by dereckson on Feb 11 2016, 01:51.
Tags
None
Referenced Files
F3768214: D280.diff
Sat, Nov 23, 07:10
Unknown Object (File)
Tue, Nov 12, 08:22
Unknown Object (File)
Sun, Nov 10, 20:34
Unknown Object (File)
Sun, Nov 10, 03:17
Unknown Object (File)
Sat, Nov 9, 14:51
Unknown Object (File)
Thu, Nov 7, 22:26
Unknown Object (File)
Wed, Nov 6, 04:45
Unknown Object (File)
Wed, Nov 6, 03:29
Subscribers

Details

Summary

The responsibility to determine the default group were located
inside GitHubPayloadAnalyzer.

As, this is a pure configuration setting, the responsibility is
moved to GitHubPayloadAnalyzerConfiguration.

A constructor is added, to specify project, so we can do two things:

  • in this change, determine a fallback default group when omitted from the configuration
  • in a next change, give it the responsibility to load JSON config
Test Plan

phpunit

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson retitled this revision from to GitHubPayloadAnalyzerConfiguration::getDefaultGroup().
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson edited edge metadata.
dereckson added inline comments.
app/Analyzers/GitHub/GitHubPayloadAnalyzerConfiguration.php
63

This syntax works for phpdoc, as shown in test documentation

This revision is now accepted and ready to land.Feb 11 2016, 04:44
This revision was automatically updated to reflect the committed changes.