Paths

Table of Contentst

Differential D2653

Modernize code to PHP 8.1 standard
ClosedPublic
Actions

Authored by dereckson on Apr 9 2022, 07:50.

Tags

None

Referenced Files

	F11039170: D2653.diff
	Sun, Aug 10, 14:45

	Unknown Object (File)
	Sat, Aug 9, 10:26

	Unknown Object (File)
	Thu, Aug 7, 09:13

	Unknown Object (File)
	Wed, Aug 6, 17:24

	Unknown Object (File)
	Wed, Aug 6, 16:35

	Unknown Object (File)
	Wed, Aug 6, 16:30

	Unknown Object (File)
	Wed, Aug 6, 16:20

	Unknown Object (File)
	Wed, Aug 6, 15:02

Subscribers

None

Details

Reviewers

Commits

rKCMDbaf6e15c21a8: Modernize code to PHP 8.1 standard
rKERUALD274a34db1539: Modernize code to PHP 8.1 standard

Summary

Don't use enum to avoid constructions like ExitCode::SUCCESS->value.

Test Plan

Run tests and phan

Diff Detail

Repository

rKERUALD Keruald libraries development repository

Lint

Lint Passed

Unit

Test Failures

Branch

modernize-commands-php81

Build Status

Buildable 4160
Build 4412: arc lint + arc unit

Unit TestsBroken
View All

	Time	Test
	0 ms	Keruald\Commands\Tests\CommandTest Keruald\Commands\Tests\CommandTest::testGetArgc Error: Class "Keruald\Commands\Display\ArrayDisplay" not found
	0 ms	Keruald\Commands\Tests\Display\ArrayDisplayTest Keruald\Commands\Tests\Display\ArrayDisplayTest::testOut Error: Class "Keruald\Commands\Display\ArrayDisplay" not found

Event Timeline

dereckson requested review of this revision.Apr 9 2022, 07:50

dereckson created this revision.

Harbormaster completed remote builds in B4160: Diff 6704.Apr 9 2022, 07:50

For the tests, the composer.json commit for all libraries hasn't been merged yet.

dereckson added a parent revision: D2547: Generate composer.json.Apr 9 2022, 07:53

Rebased

Harbormaster completed remote builds in B4161: Diff 6706.Apr 9 2022, 08:06

dereckson accepted this revision.Apr 9 2022, 08:07

This revision is now accepted and ready to land.Apr 9 2022, 08:07

Closed by commit rKERUALD274a34db1539: Modernize code to PHP 8.1 standard (authored by dereckson). · Explain WhyApr 9 2022, 08:07

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKERUALD274a34db1539: Modernize code to PHP 8.1 standard.

dereckson added a commit: rKCMDbaf6e15c21a8: Modernize code to PHP 8.1 standard.Jul 2 2023, 18:53

Revision Contents
Changeset List

Path

Size

commands/

2 lines

2 lines

src/

34 lines

Display/

ArrayDisplay.php

8 lines

Diff 6704

commands/LICENSE

Loading...

commands/composer.json

Loading...

commands/src/Command.php

Loading...

commands/src/Display/ArrayDisplay.php

Loading...