Differential D2677

Refer to service container property instead of using global helper
ClosedPublic
Actions

Authored by dereckson on Apr 23 2022, 08:34.

Tags

None

Referenced Files

	F3765989: D2677.id6770.diff
	Fri, Nov 22, 15:48

	F3765138: D2677.diff
	Fri, Nov 22, 10:37

	Unknown Object (File)
	Wed, Nov 20, 11:17

	Unknown Object (File)
	Wed, Nov 20, 00:07

	Unknown Object (File)
	Wed, Nov 13, 23:08

	Unknown Object (File)
	Mon, Nov 11, 07:19

	Unknown Object (File)
	Thu, Nov 7, 15:12

	Unknown Object (File)
	Sun, Nov 3, 22:57

Subscribers

None

Details

Reviewers

DorianWinty
dereckson

Commits

rNOTIF5365c197439c: Refer to service container property instead of using global helper

Summary

The Illuminate\Foundation\Exceptions\Handler constructor requires
the full container in the constructor, using a service locator pattern.

Test Plan

Run tests

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

Test Failures

Branch

fix-handlertest

Build Status

Buildable 4206
Build 4458: arc lint + arc unit

Unit TestsBroken
View All

	Time	Test
	0 ms	/usr/home/dereckson/dev/nasqueron/notifications/notifications/tests/Exceptions/HandlerTest.php Fatal error: Declaration of Nasqueron\Notifications\Tests\Exceptions\HandlerTest::setUp() must be compatible with Illuminate\Foundation\Testing\TestCase::setUp(): void in /usr/home/dereckson/dev/nasqueron/notifications/notifications/tests/Exceptions/HandlerTest.php on line 25

Event Timeline

dereckson requested review of this revision.Apr 23 2022, 08:34

dereckson created this revision.

Harbormaster completed remote builds in B4206: Diff 6770.Apr 23 2022, 08:34

DorianWinty accepted this revision.Apr 23 2022, 12:08

This revision is now accepted and ready to land.Apr 23 2022, 12:08

dereckson accepted this revision.May 7 2022, 19:25

This revision was landed with ongoing or failed builds.May 7 2022, 19:31

Closed by commit rNOTIF5365c197439c: Refer to service container property instead of using global helper (authored by dereckson). · Explain Why

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rNOTIF5365c197439c: Refer to service container property instead of using global helper.

Revision Contents
Changeset List

Path

Size

tests/

Exceptions/

HandlerTest.php

2 lines

Diff 6770

tests/Exceptions/HandlerTest.php

Loading...