Refer to service container property instead of using global helper
ClosedPublic
Actions

Authored by dereckson on Apr 23 2022, 08:34.

Tags

None

Referenced Files

	F12433198: D2677.id6783.diff
	Wed, Nov 5, 20:21

	F12432236: D2677.id6770.diff
	Wed, Nov 5, 18:16

	F12431299: D2677.diff
	Wed, Nov 5, 16:13

	Unknown Object (File)
	Mon, Nov 3, 17:23

	Unknown Object (File)
	Sun, Nov 2, 23:42

	Unknown Object (File)
	Sat, Nov 1, 02:03

	Unknown Object (File)
	Tue, Oct 28, 06:42

	Unknown Object (File)
	Sat, Oct 25, 17:09

View All Files

Subscribers

None

Details

Reviewers

DorianWinty
dereckson

Commits

rNOTIF5365c197439c: Refer to service container property instead of using global helper

Summary

The Illuminate\Foundation\Exceptions\Handler constructor requires
the full container in the constructor, using a service locator pattern.

Test Plan

Run tests

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Apr 23 2022, 08:34

dereckson created this revision.

Harbormaster completed remote builds in B4206: Diff 6770.Apr 23 2022, 08:34

DorianWinty accepted this revision.Apr 23 2022, 12:08

This revision is now accepted and ready to land.Apr 23 2022, 12:08

dereckson accepted this revision.May 7 2022, 19:25

This revision was landed with ongoing or failed builds.May 7 2022, 19:31

Closed by commit rNOTIF5365c197439c: Refer to service container property instead of using global helper (authored by dereckson). · Explain Why

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rNOTIF5365c197439c: Refer to service container property instead of using global helper.

Revision Contents
Changeset List

Path

Size

tests/

Exceptions/

HandlerTest.php

2 lines

Diff 6783

View Options

tests/Exceptions/HandlerTest.php

Refer to service container property instead of using global helperClosedPublicActions