Page MenuHomeDevCentral

Optimize Handler::report
ClosedPublic

Authored by dereckson on Mar 2 2016, 10:34.
Tags
None
Referenced Files
F10848801: D313.id739.diff
Wed, Jul 30, 11:57
Unknown Object (File)
Tue, Jul 29, 13:41
Unknown Object (File)
Tue, Jul 29, 02:58
Unknown Object (File)
Mon, Jul 28, 22:53
Unknown Object (File)
Mon, Jul 28, 22:26
Unknown Object (File)
Sun, Jul 27, 22:15
Unknown Object (File)
Sat, Jul 26, 13:18
Unknown Object (File)
Fri, Jul 25, 18:54
Subscribers

Details

Summary

Parent class method check the $dontReport array, then
log the exception.

As we have more logic, and this logic also require to
check what we want to report, we would check twice this
condition.

So we handle all the report logic in our class method,
without calling the parent class method anymore.

Test Plan

Run tests.

A new test for an unreportable exception has been added.

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson retitled this revision from to Optimize Handler::report.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson edited edge metadata.
This revision is now accepted and ready to land.Mar 2 2016, 10:48

Class is fully tested according report coverage, so it's fine.

This revision was automatically updated to reflect the committed changes.