Handle .geoipupdate lock file
ClosedPublic
Actions

Authored by dereckson on Mar 16 2023, 19:14.

Tags

None

Referenced Files

	F4017172: D2902.id7397.diff
	Sat, Jan 18, 03:33

	F4016149: D2902.diff
	Sat, Jan 18, 00:32

	F4014978: D2902.id7396.diff
	Fri, Jan 17, 21:48

	F4014387: D2902.id7396.diff
	Fri, Jan 17, 20:42

	Unknown Object (File)
	Mon, Jan 13, 07:52

	Unknown Object (File)
	Sun, Jan 12, 04:22

	Unknown Object (File)
	Thu, Jan 9, 20:24

	Unknown Object (File)
	Thu, Jan 9, 02:47

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rOPS8a59aa7594c2: Handle .geoipupdate lock file

Summary

The geoipupdate client creates a lockfile to avoid race conditions.

Drawbacks of the current method is:

no lock file created at first run
can be confusing to see it afterwards

To address both those concerns, the wrapper creates and deletes
this lock file before and after the container run.

Reference: https://github.com/maxmind/geoipupdate-legacy/issues/79

Test Plan

Tested on docker-002

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Passed

Unit

No Test Coverage

Branch

main

Build Status

Buildable 4578
Build 4846: arc lint + arc unit

Event Timeline

dereckson created this revision.Mar 16 2023, 19:14

Harbormaster completed remote builds in B4578: Diff 7396.Mar 16 2023, 19:14

dereckson requested review of this revision.Mar 16 2023, 19:14

dereckson accepted this revision.Mar 16 2023, 19:15

This revision is now accepted and ready to land.Mar 16 2023, 19:15

Closed by commit rOPS8a59aa7594c2: Handle .geoipupdate lock file (authored by dereckson). · Explain WhyMar 16 2023, 19:15

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rOPS8a59aa7594c2: Handle .geoipupdate lock file.

Revision Contents
Changeset List

Path

Size

roles/

paas-docker/

wrappers/

files/

geoipupdate.sh

4 lines

Diff 7396

View Options

roles/paas-docker/wrappers/files/geoipupdate.sh

Handle .geoipupdate lock fileClosedPublicActions