Throw RuntimeException when Phabricator API call fails.
ClosedPublic
Actions

Authored by dereckson on Mar 2 2016, 17:31.

Details

Reviewers

dereckson

Commits

rNOTIF215b08e278be: Throw RuntimeException when Phabricator API call fails.

Summary

The Phabricator API is called through curl. If the session fails, we
now throw an exception instead to return false in Phabricator::post.

Test Plan

Call config:show command in unit test context.

An exception should be thrown, as phabricator.acme.tld shouldn't succeed.

Formal tests to come in D241.

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

No Test Coverage

Branch

fix/PhabricatorAPI

Event Timeline

dereckson updated this revision to Diff 742.Mar 2 2016, 17:31

dereckson retitled this revision from to Throw RuntimeException when Phabricator API call fails..

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

Build started: https://ci.nasqueron.org/job/test-notifications-phab/98/ (console: https://ci.nasqueron.org/job/test-notifications-phab/98/console)

dereckson added a child revision: D241: Tests for config:show console command.Mar 2 2016, 17:34

Build is green https://ci.nasqueron.org/job/test-notifications-phab/98/ for more details.

dereckson accepted this revision.Mar 2 2016, 17:43

dereckson edited edge metadata.

This revision is now accepted and ready to land.Mar 2 2016, 17:43

Closed by commit rNOTIF215b08e278be: Throw RuntimeException when Phabricator API call fails. (authored by dereckson, committed by dereckson). · Explain WhyMar 2 2016, 17:43

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

app/

Phabricator/

PhabricatorAPI.php

5 lines

Diff 742

View Options

app/Phabricator/PhabricatorAPI.php

Throw RuntimeException when Phabricator API call fails.ClosedPublicActions