Differential D2916

Enable sockets extension
ClosedPublic
Actions

Authored by dereckson on Mar 25 2023, 13:38.

Details

Reviewers

dereckson

Maniphest Tasks

T1800: Ensure PHP sockets extension is available everywhere

Commits

rDPHPCLI1d78152e54c1: Enable sockets extension

Summary

The sockets extension is used by php-amqplib, used by keruald/broker,
and so by Notifications Center to connect to RabbitMQ.

Jenkins PHP agents to run CI jobs for Notifications Center uses
this Docker image as base, so the sockets extension has to be added
in one of those two repositories.

Fedora PHP maintainers include sessions in the standard extensions package
php-common, so it's probably a good candidate here.

Reference: https://github.com/php-amqplib/php-amqplib/issues/608

Ref T1800

Test Plan

Run Notifications CI job

Diff Detail

Repository

rDPHPCLI nasqueron/php-cli Docker image

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

sockets

Build Status

Buildable 4597
Build 4869: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Mar 25 2023, 13:38

dereckson created this revision.

Harbormaster completed remote builds in B4596: Diff 7428.Mar 25 2023, 13:38

Rebased against D2915.

Harbormaster completed remote builds in B4597: Diff 7430.Mar 25 2023, 13:41

Dwellers

$ docker build .
[…]
 => => writing image sha256:a6682dbc98cdbbd455263de28a47da8147a06d57eee249d47493a87449b97d4e

$ docker run a6682dbc98cdbbd455263de28a47da8147a06d57eee249d47493a87449b97d4e php -i | grep -i sockets
Configure Command =>  './configure'  '--with-config-file-path=/usr/local/etc/php' '--with-config-file-scan-dir=/usr/local/etc/php/conf.d' '--disable-cgi' '--enable-mysqlnd' '--enable-bcmath' '--with-bz2' '--enable-calendar' '--with-curl' '--enable-gd' '--with-jpeg' '--enable-ftp' '--with-libedit' '--enable-mbstring' '--with-mysqli' '--with-pdo-mysql' '--enable-pcntl' '--with-openssl' '--with-xsl' '--with-readline' '--enable-sockets' '--with-zlib' '--with-zip' '--with-pear'
UNIX_SOCKETS => Yes
sockets
Sockets Support => enabled