Page MenuHomeDevCentral
Differential D2957

Log gate response
ClosedPublic
Actions

Authored by dereckson on Mar 31 2023, 16:55.
Tags
None
Referenced Files
F3747216: D2957.id7546.diff
Sat, Nov 16, 01:02
F3747215: D2957.id7538.diff
Sat, Nov 16, 01:02
Unknown Object (File)
Wed, Nov 13, 15:00
Unknown Object (File)
Tue, Nov 12, 09:39
Unknown Object (File)
Tue, Nov 12, 01:26
Unknown Object (File)
Thu, Nov 7, 23:25
Unknown Object (File)
Thu, Nov 7, 06:17
Unknown Object (File)
Sat, Nov 2, 04:29
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rNOTIF41818fbb66e9: Log gate response
Summary

For better visibility and contxt in Sentry, log the response sent to
the automated service with how the notification has been processed.

Test Plan
  • Units tests added to omnitools for the toArray() method
  • Once deployed, Sentry should get two new new log.info entries

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson created this revision.Mar 31 2023, 16:55
alken-orin added a comment.Mar 31 2023, 16:55

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/280/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/280/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 31 2023, 16:55
Harbormaster failed remote builds in B4661: Diff 7538!
alken-orin added a comment.Mar 31 2023, 21:27

Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/281/ for more details.

alken-orin added a comment.Mar 31 2023, 21:28

Build is green
See https://ci.nasqueron.org/job/test-notifications-phab/282/ for more details.

Harbormaster completed remote builds in B4661: Diff 7538.Mar 31 2023, 21:28
dereckson requested review of this revision.Mar 31 2023, 21:28
dereckson accepted this revision.Mar 31 2023, 21:29
This revision is now accepted and ready to land.Mar 31 2023, 21:29
Closed by commit rNOTIF41818fbb66e9: Log gate response (authored by dereckson). · Explain WhyMar 31 2023, 21:30
This revision was automatically updated to reflect the committed changes.
dereckson added a commit: rNOTIF41818fbb66e9: Log gate response.

Revision Contents
Changeset List

PathSize
app/
Actions/
9 lines
Http/
Controllers/
Gate/
12 lines
1 line

Diff 7546

View Options

app/Actions/ActionsReport.php

Loading...
View Options

app/Http/Controllers/Gate/GateController.php

Loading...
View Options

composer.json

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator