Fix type error when data isn't cached in ProjectsMap
ClosedPublic
Actions

Authored by dereckson on Mar 3 2016, 19:24.

Details

Reviewers

Commits

rNOTIFb26c9938c1e5: Fix type error when data isn't cached in ProjectsMap

Summary

When the cache doesn't contain a map, and loadFromCache method were
called, the map private property (with [] as default value) received
null value instead.

This fixes allow the offsetExists method to work in this scenario.

Test Plan

Run cache tests from D324

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

No Test Coverage

Branch

cache

Event Timeline

dereckson updated this revision to Diff 768.Mar 3 2016, 19:24

dereckson retitled this revision from to Fix type error when data isn't cached in ProjectsMap.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson added a child revision: D324: Tests for ProjectsMap.Mar 3 2016, 19:25

Build started: https://ci.nasqueron.org/job/test-notifications-phab/114/ (console: https://ci.nasqueron.org/job/test-notifications-phab/114/console)

Build is green https://ci.nasqueron.org/job/test-notifications-phab/114/ for more details.

dereckson accepted this revision.Mar 3 2016, 19:37

dereckson edited edge metadata.

This revision is now accepted and ready to land.Mar 3 2016, 19:37

Closed by commit rNOTIFb26c9938c1e5: Fix type error when data isn't cached in ProjectsMap (authored by dereckson, committed by dereckson). · Explain WhyMar 3 2016, 19:37

This revision was automatically updated to reflect the committed changes.

dereckson mentioned this in D324: Tests for ProjectsMap.Mar 3 2016, 19:49

Revision Contents
Changeset List

Path

Size

app/

Phabricator/

ProjectsMap.php

7 lines

Diff 768

View Options

app/Phabricator/ProjectsMap.php

Fix type error when data isn't cached in ProjectsMapClosedPublicActions