Differential D334

API dependency injection for ProjectsMap
ClosedPublic
Actions

Authored by dereckson on Mar 9 2016, 06:02.

Details

Reviewers

dereckson

Commits

rNOTIF123f184ddad5: API dependency injection for ProjectsMap

Summary

This commit also reverts 8758ba5 and improves fea5b9c.

Test Plan

New tests for ProjectsMap

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

Tests Passed

Branch

test/ProjectsMap

Event Timeline

dereckson updated this revision to Diff 794.Mar 9 2016, 06:02

dereckson retitled this revision from to API dependency injection for ProjectsMap.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

Build started: https://ci.nasqueron.org/job/test-notifications-phab/119/ (console: https://ci.nasqueron.org/job/test-notifications-phab/119/console)

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/119/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/119/console

Build started: https://ci.nasqueron.org/job/test-notifications-phab/120/ (console: https://ci.nasqueron.org/job/test-notifications-phab/120/console)

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/120/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/120/console

Rebased against D333.

dereckson accepted this revision.Aug 10 2016, 19:50

dereckson edited edge metadata.

This revision is now accepted and ready to land.Aug 10 2016, 19:50

Closed by commit rNOTIF123f184ddad5: API dependency injection for ProjectsMap (authored by dereckson, committed by dereckson). · Explain WhyAug 10 2016, 19:51

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

app/

Phabricator/

ProjectsMap.php

6 lines

95%

tests/

Phabricator/

ProjectsMapTest.php

28 lines

Diff 794

View Options

app/Phabricator/ProjectsMap.php