Restore metrics collector in management plugin
ClosedPublic
Actions

Authored by dereckson on May 30 2023, 19:24.

Details

Reviewers

Commits

rDRABBITMQ41cfea3ddaac: Restore metrics collector in management plugin

Summary

The base image disable explicitly fot the management plugin
the metrics collector and associated UI to avoid redundancy
with Prometheus metrics.

Metrics in the UI for queues is something useful to debug
in an unified place, even with dashboards on the side.

For a discussion on metrics collection, see also T1623 and T1633.

Test Plan

Deploy for white-rabbit and orange-rabbit

Diff Detail

Repository

rDRABBITMQ RabbitMQ Docker image

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

main

Build Status

Buildable 4981
Build 5262: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.May 30 2023, 19:24

dereckson created this revision.

Harbormaster completed remote builds in B4981: Diff 8057.May 30 2023, 19:24

Still "Stats in management UI are disabled on this node"

This revision is now accepted and ready to land.May 30 2023, 19:27

dereckson planned changes to this revision.May 30 2023, 19:27

dereckson added inline comments.

Dockerfile
7	with BuildKit I'm not sure that's a good idea to remove a file

Hmmm they prioritized the configuration to load in a specific order, so now it's 20-management_agent.disable_metrics_collector.conf

They change again the config, BOOM we lose it again.

Regardless of the previous remark on the lack of stability of upstream image, we can currently proceed.

Update configuration file name

This revision is now accepted and ready to land.May 30 2023, 19:34

Harbormaster completed remote builds in B4982: Diff 8058.May 30 2023, 19:34

dereckson accepted this revision.May 30 2023, 19:34

Closed by commit rDRABBITMQ41cfea3ddaac: Restore metrics collector in management plugin (authored by dereckson). · Explain WhyMay 30 2023, 19:34

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rDRABBITMQ41cfea3ddaac: Restore metrics collector in management plugin.

Revision Contents
Changeset List

Path

Size

Dockerfile

3 lines

Diff 8057

View Options

Restore metrics collector in management pluginClosedPublicActions