Paths

Table of Contentst

Differential D3244

Update mockito to latest version
ClosedPublic
Actions

Authored by EshaanAgg on Sep 10 2023, 18:21.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 27, 05:52

	Unknown Object (File)
	Thu, Dec 26, 23:13

	Unknown Object (File)
	Thu, Dec 26, 23:13

	Unknown Object (File)
	Thu, Dec 26, 23:13

	Unknown Object (File)
	Thu, Dec 26, 23:13

	Unknown Object (File)
	Fri, Dec 20, 12:30

	Unknown Object (File)
	Fri, Dec 13, 20:14

	Unknown Object (File)
	Fri, Dec 13, 19:55

Subscribers

None

Details

Reviewers

Maniphest Tasks

T1876: Upgrade mockito code to 1.x

Commits

rDS19378908c94e: Update mockito to latest version

Diff Detail

Repository

rDS Nasqueron Datasources

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

UpgradeMockito

Build Status

Buildable 5118
Build 5399: arc lint + arc unit

Event Timeline

EshaanAgg requested review of this revision.Sep 10 2023, 18:21

EshaanAgg created this revision.

Harbormaster completed remote builds in B5116: Diff 8334.Sep 10 2023, 18:21

dereckson added a task: T1876: Upgrade mockito code to 1.x.Sep 10 2023, 18:28

Issue: T1876

Harbormaster completed remote builds in B5117: Diff 8335.Sep 10 2023, 18:28

EshaanAgg mentioned this in T1876: Upgrade mockito code to 1.x.Sep 10 2023, 18:29

dereckson added a reviewer: dereckson.Sep 10 2023, 19:12

dereckson added inline comments.Sep 10 2023, 19:19

opendatasoft-explore-api/Cargo.toml
26–27	Perhaps we can now remove this line.
opendatasoft-explore-api/tests/requests_test.rs
58	If we use the full variable name we'll avoid a question "what's that `s` lost at the end of the method?"

Thanks for the upgrade. Will have a look.

We can also prepare a CI job on Jenkins now we've tests to run.

upd: Incorporate changes mentioned in review

Harbormaster completed remote builds in B5118: Diff 8336.Sep 11 2023, 06:30

@dereckson Added the suggested changes. We can work on adding a Jenkin's pipeline in a new issue to keep the issues isolated and to the point. Does that work?

D2344.log2 KBDownload

All tests pass successfully o/

dereckson accepted this revision.Sep 21 2023, 16:10

dereckson retitled this revision from chore: Update mockito to latest version to Update mockito to latest version.

This revision is now accepted and ready to land.Sep 21 2023, 16:10

Closed by commit rDS19378908c94e: Update mockito to latest version (authored by EshaanAgg, committed by dereckson). · Explain WhySep 21 2023, 16:11

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rDS19378908c94e: Update mockito to latest version.

dereckson attached a referenced file: F2299622: D2344.log. (Show Details)Sep 21 2023, 16:11

Revision Contents
Changeset List

Path

Size

opendatasoft-explore-api/

3 lines

tests/

requests_test.rs

142 lines

Diff 8336

opendatasoft-explore-api/Cargo.toml

Loading...

opendatasoft-explore-api/tests/requests_test.rs

Loading...