Allow to restart php-fpm on FreeBSD servers after PHP update
ClosedPublic
Actions

Authored by dereckson on Jun 19 2024, 19:01.

Details

Reviewers

DorianWinty

Commits

rOPS0ba9786b3856: Allow to restart php-fpm on FreeBSD servers after PHP update

Summary

On FreeBSD, some services can received an extra argument
to launch it several times. We provision a custom php-fpm
service to exactly do that: we want to be able to run several
pools with different PHP versions or configuration.

When the package is reinstalled, for example during a package update,
the custom service is overwritten.

The restart-php-fpm command checks the service is the Nasqueron one,
and if not, call Salt to redeploy it. Then, it restart the service.

Test Plan

Tested on WindRiver with:

pkg update
pkg upgrade
restart-php-fpm

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	roles/webserver-alkane/php/files/restart-php-fpm.sh:20	SC3028	SHELLCHECK

Unit

No Test Coverage

Branch

restart-php-fpm

Build Status

Buildable 5284
Build 5565: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Jun 19 2024, 19:01

dereckson created this revision.

Harbormaster completed remote builds in B5284: Diff 8584.Jun 19 2024, 19:01

$ sudo salt-call --local state.sls roles/webserver-alkane/php/service                                                                                                                  [7/153]
local:                                                                                                                                                                                        
----------                                                                                     
          ID: /usr/local/etc/rc.d/php-fpm                                                                                                                                                     
    Function: file.managed                                                                     
      Result: True                                                                             
     Comment: File /usr/local/etc/rc.d/php-fpm is in the correct state                         
     Started: 18:49:38.779911                                                                  
    Duration: 7.874 ms                                                                         
     Changes:                                                                                  
----------                                                                                                                                                                                    
          ID: /usr/local/bin/restart-php-fpm                                                                                                                                                  
    Function: file.managed                                                                                                                                                                    
      Result: True                                                                             
     Comment: File /usr/local/bin/restart-php-fpm updated                                      
     Started: 18:49:38.787861                                                                                                                                                                 
    Duration: 4.183 ms                                                                                                                                                                        
     Changes:                                                                                                                                                                                 
              ----------                                                                                                                                                                      
              diff:                                                                            
                  New file                                                                     
              mode:                                                                                                                                                                           
                  0755                                                                                                                                                                        
----------
[...]
Summary for local
------------
Succeeded: 5 (changed=1)
Failed:    0
------------
Total states run:     5
Total run time:  20.132 ms