Sorted by numerical order

Should match uid, so 1001

Open question:

Should we declare software versions and hashes directly in roles or use pillar to store that information?

I don't have a definite opinion on that question and generally put this kind of information directly in roles/.

Pillar could simply be:

netbox:
  release:
     tag: v3.7.1
     hash: 97ea9106b6d29e2568c4e9c395013ca015ba7521029e8c907b6aa515dd62649a

New server CPU is 6 core, 12 threads

To avoid to read sysctl kern.sched.topology_spec, probably the easiest way to get this value is to use Salt grains.

No need to divide by 2 as it gives the number of CPU threads, not of core.

That's OS-level thread, not CPU thread, so we can keep this value.