Stop using deprecated cgi module
ClosedPublic
Actions

Authored by dereckson on Oct 18 2024, 20:55.

Details

Reviewers

dereckson

Maniphest Tasks

T2041: Python 3.13 will remove cgi library used by woof

Commits

rWURF4ceba4deb470: Stop using deprecated cgi module

Summary

The cgi module has been deprecated and will be removed in Python 3.13.

Side edits:

adhere more to Python conventions
improve HTML doctype
proofread messages

Original author: CoolCat467
Source: https://github.com/simon-budig/woof/pull/21

Fixes T2041.

Test Plan

woof CONTRIBUTORS.md
woof archiv/
woof -U (without upload)
woof -U, then compare file hashes

Diff Detail

Repository

rWURF wurf

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

drop-cgi-module-support (branched from replace-cgi)

Build Status

Buildable 5615
Build 5897: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Oct 18 2024, 20:55

dereckson created this revision.

Harbormaster completed remote builds in B5615: Diff 9084.Oct 18 2024, 20:55

Please note I'm NOT the author of that code change, this change is from https://github.com/CoolCat467

dereckson accepted this revision.Oct 18 2024, 21:04

dereckson added inline comments.

woof
146	That's a good question how to detect if the upload has been interrupted. Normally, that happens with a server when there is a timeout issue, so at this stage of the code I'm not sure it could be reached.

This revision is now accepted and ready to land.Oct 18 2024, 21:04

Closed by commit rWURF4ceba4deb470: Stop using deprecated cgi module (authored by CoolCat467 <52022020+CoolCat467@users.noreply.github.com>, committed by dereckson). · Explain WhyOct 18 2024, 21:06

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rWURF4ceba4deb470: Stop using deprecated cgi module.

Revision Contents
Changeset List

Path

Size

woof

121 lines

Diff 9084

View Options

Stop using deprecated cgi moduleClosedPublicActions