Page MenuHomeDevCentral

Stop using deprecated cgi module
ClosedPublic

Authored by dereckson on Oct 18 2024, 20:55.
Tags
None
Referenced Files
F4045969: D3536.id.diff
Wed, Jan 22, 20:24
F4045838: D3536.diff
Wed, Jan 22, 19:13
F4045161: D3536.id9084.diff
Wed, Jan 22, 16:27
Unknown Object (File)
Tue, Jan 21, 01:10
Unknown Object (File)
Mon, Jan 20, 13:07
Unknown Object (File)
Mon, Jan 20, 13:07
Unknown Object (File)
Sun, Jan 19, 15:55
Unknown Object (File)
Sun, Jan 19, 15:55
Subscribers
None

Details

Summary

The cgi module has been deprecated and will be removed in Python 3.13.

Side edits:

  • adhere more to Python conventions
  • improve HTML doctype
  • proofread messages

Original author: CoolCat467
Source: https://github.com/simon-budig/woof/pull/21

Fixes T2041.

Test Plan
  • woof CONTRIBUTORS.md
  • woof archiv/
  • woof -U (without upload)
  • woof -U, then compare file hashes

Diff Detail

Repository
rWURF wurf
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
drop-cgi-module-support (branched from replace-cgi)
Build Status
Buildable 5615
Build 5897: arc lint + arc unit

Event Timeline

dereckson created this revision.

Please note I'm NOT the author of that code change, this change is from https://github.com/CoolCat467

dereckson added inline comments.
woof
146

That's a good question how to detect if the upload has been interrupted.

Normally, that happens with a server when there is a timeout issue, so at this stage of the code I'm not sure it could be reached.

This revision is now accepted and ready to land.Oct 18 2024, 21:04