Details

Reviewers

dereckson
DorianWinty

Commits

rUPSECTION3f7af1045937: Verify config.yml exists

Test Plan

Launch the project when the config.yml does not exist

Diff Detail

Repository

rUPSECTION Upsection

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

MoustaphaAs requested review of this revision.Wed, Oct 30, 09:28

MoustaphaAs created this revision.

Harbormaster completed remote builds in B5656: Diff 9180.Wed, Oct 30, 09:28

Change the link of the documentation

Harbormaster completed remote builds in B5657: Diff 9181.Wed, Oct 30, 09:34

Changing error message into stderr

Harbormaster completed remote builds in B5658: Diff 9182.Wed, Oct 30, 10:53

dereckson requested changes to this revision.Wed, Nov 6, 21:18

dereckson added inline comments.

src/upsection.py
43	Should be rebased against a08a2b78bf7c

This revision now requires changes to proceed.Wed, Nov 6, 21:18

Also, just FYI, you've used mous and windriver.nasqueron.org as committer address. This is the default when Git isn't configured to take username@hostname. If you've now created a ~/.gitconfig file on WindRiver too, you can change that with git commit --amend --reset-author.

DorianWinty retitled this revision from Update adding a try-catch for the config.yml file to Init try-catch for the config.yml file.Wed, Nov 20, 19:54

DorianWinty edited the summary of this revision. (Show Details)

DorianWinty edited the test plan for this revision. (Show Details)

Rebase and change author

Harbormaster completed remote builds in B5722: Diff 9277.Wed, Nov 20, 20:43

MoustaphaAs retitled this revision from Init try-catch for the config.yml file to Verify config.yml exist.Wed, Nov 20, 20:45

MoustaphaAs edited the test plan for this revision. (Show Details)

MoustaphaAs retitled this revision from Verify config.yml exist to Verify config.yml exists.

DorianWinty accepted this revision.Wed, Nov 20, 20:49

dereckson accepted this revision.Wed, Nov 20, 20:49

This revision is now accepted and ready to land.Wed, Nov 20, 20:49

This revision was landed with ongoing or failed builds.Wed, Nov 20, 20:56

Closed by commit rUPSECTION3f7af1045937: Verify config.yml exists (authored by MoustaphaAs). · Explain Why