Page MenuHomeDevCentral

Provision devcentral local configuration
Needs ReviewPublic

Authored by DorianWinty on Thu, Jan 2, 20:49.
Tags
None
Referenced Files
F3976404: D3623.id9370.diff
Mon, Jan 6, 04:32
Unknown Object (File)
Sun, Jan 5, 14:40
Unknown Object (File)
Sun, Jan 5, 03:41
Unknown Object (File)
Sat, Jan 4, 12:49
Unknown Object (File)
Sat, Jan 4, 02:10
Unknown Object (File)
Sat, Jan 4, 02:08
Unknown Object (File)
Sat, Jan 4, 02:08
Unknown Object (File)
Sat, Jan 4, 02:07
Subscribers
None
Tokens
"Evil Spooky Haunted Tree" token, awarded by dereckson.

Details

Summary

This will permit to manage devcentral configuration easily

Ref T2099

Test Plan

salt docker-002 state.sls_id /srv/phabricator/devcentral/conf/local/local.json roles/paas-docker/containers/phabricator

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Errors
SeverityLocationCodeMessage
Errorroles/paas-docker/containers/files/phabricator/devcentral/config.json:9JSON1Parse Error
Unit
No Test Coverage
Branch
localConfigDevcentral
Build Status
Buildable 5781
Build 6063: arc lint + arc unit

Event Timeline

DorianWinty created this revision.
dereckson requested changes to this revision.Fri, Jan 3, 11:40
dereckson added inline comments.
roles/paas-docker/containers/files/phabricator/devcentral/config.json
3

We can reuse all the first line from usual template.

10

we can rename the file config.json.jinja (in our repo) to avoid lint

54

I would add blank lines for different first words:

phabricator.show...
phabricator.base...
<blank line>
phd....
<blank line>
pyg
<blank line>
storage
<blank line>
security

roles/paas-docker/containers/phabricator.sls
33

We can also use get_password here and store the secret under the key "password" on Vault, that's what we do with every other API key.

(I see a get_token below, that was historically for Zemke-Rhyne, credentials.get_token is an alias for credentials.get_password)

This revision now requires changes to proceed.Fri, Jan 3, 11:40

I like it, that's a good step to improve automation for DevCentral container.

DorianWinty marked 3 inline comments as done.

edit following comment

DorianWinty marked an inline comment as done.

v2 edit following comments

The configuration option "_comment" is not recognized. It may be misspelled, or it might have existed in an older version of the software. It has no effect, and should be corrected or deleted.

Seems Phabricator doesn't like extra keys.