Page MenuHomeDevCentral
Differential D3626

Permit safe reload of nginx
ClosedPublic
Actions

Authored by DorianWinty on Mar 12 2025, 21:29.
Tags
None
Referenced Files
F6965922: D3626.id9387.diff
Fri, Apr 18, 07:56
F6956739: D3626.id9378.diff
Fri, Apr 18, 03:11
F6956735: D3626.id9378.diff
Fri, Apr 18, 03:11
F6925364: D3626.diff
Thu, Apr 17, 11:10
Unknown Object (File)
Wed, Apr 16, 18:14
Unknown Object (File)
Tue, Apr 15, 12:42
Unknown Object (File)
Tue, Apr 15, 02:13
Unknown Object (File)
Mon, Apr 14, 17:31
View All 42 Files
Subscribers
None

Details

Reviewers
dereckson
Maniphest Tasks
T2098: acme.sh configure provisionning of the nginx check and reload
Commits
rOPSb73f67ee791e: Permit safe reload of nginx
Summary

Ref T2098

Test Plan

Deploy this diff and try to renew a certificate how have the script added

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Passed
Unit
No Test Coverage
Branch
reloadCheck
Build Status
Buildable 5789
Build 6071: arc lint + arc unit

Event Timeline

DorianWinty requested review of this revision.Mar 12 2025, 21:29
DorianWinty created this revision.
Harbormaster completed remote builds in B5789: Diff 9378.Mar 12 2025, 21:29
dereckson requested changes to this revision.Mar 13 2025, 17:31

Looks good to me, source file to update.

roles/core/certificates/files/acmesh-nginxCheck.sh
8

New path?

8

?

This revision now requires changes to proceed.Mar 13 2025, 17:31
DorianWinty updated this revision to Diff 9379.Wed, Mar 26, 18:02
DorianWinty marked 2 inline comments as done.

path update

Harbormaster completed remote builds in B5790: Diff 9379.Wed, Mar 26, 18:02
dereckson accepted this revision.Thu, Mar 27, 19:54
This revision is now accepted and ready to land.Thu, Mar 27, 19:54
Closed by commit rOPSb73f67ee791e: Permit safe reload of nginx (authored by DorianWinty). · Explain WhyThu, Mar 27, 20:32
This revision was automatically updated to reflect the committed changes.
DorianWinty added a commit: rOPSb73f67ee791e: Permit safe reload of nginx.

Revision Contents
Changeset List

PathSize
roles/
core/
certificates/
7 lines
files/
29 lines
1 line
sudo/
files/
16 lines
9 lines

Diff 9378

View Options

roles/core/certificates/acmesh.sls

Loading...
View Options

roles/core/certificates/files/acmesh-nginxCheck.sh

Loading...
View Options

roles/core/certificates/init.sls

Loading...
View Options

roles/core/sudo/files/acme

Loading...
View Options

roles/core/sudo/init.sls

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator