Read correctly empty configuration file
ClosedPublic
Actions

Authored by dereckson on Thu, Sep 25, 17:00.

Details

Reviewers

dereckson

Commits

rMD904396678b55: Read correctly empty configuration file

Summary

When a configuration file exists but is empty, YAML parser returns None.

This change returns an empty dict to represent the empty configuration.

This fixes the following issue for empty config file:

File "/home/dereckson/dev/python/general/lib64/python3.13/site-packages/mergedictionaries/app/app.py", line 118, in <lambda>
  self.context["config"].get("git", []), self.context["git"]
  ^^^^^^^^^^^^^^^^^^^^^^^^^^

AttributeError: 'NoneType' object has no attribute 'get'

Test Plan

create an empty configuration file
merge-dictionaries --extract

Diff Detail

Repository

rMD Merge dev dictionaries

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/mergedictionaries/app/app.py:66	E501	flake8 E501
Error	src/mergedictionaries/app/app.py:103	E501	flake8 E501

Unit

No Test Coverage

Branch

empty-git-config-issue

Build Status

Buildable 5973
Build 6255: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Thu, Sep 25, 17:00

dereckson created this revision.

Harbormaster completed remote builds in B5973: Diff 9633.Thu, Sep 25, 17:00

dereckson accepted this revision.Thu, Sep 25, 17:00

This revision is now accepted and ready to land.Thu, Sep 25, 17:00

This revision was landed with ongoing or failed builds.Thu, Sep 25, 17:01

Closed by commit rMD904396678b55: Read correctly empty configuration file (authored by dereckson). · Explain Why

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rMD904396678b55: Read correctly empty configuration file.

Revision Contents
Changeset List

Path

Size

src/

mergedictionaries/

app/

app.py

2 lines

Diff 9633

View Options

src/mergedictionaries/app/app.py

Read correctly empty configuration fileClosedPublicActions