Promote Type::getTypeOf as public helper method
ClosedPublic
Actions

Authored by dereckson on Sun, Oct 12, 13:14.

Details

Reviewers

Commits

rKOTc2e2e3391db6: Promote Type::getTypeOf as public helper method
rKERUALD48ed7a8e2753: Promote Type::getTypeOf as public helper method

Summary

Plan is to add Option after Result,
so first use case will be OmniTools internally.

Test Plan

tests for Result still pass
new test for Type::getTypeOf

Diff Detail

Repository

rKERUALD Keruald libraries development repository

Lint

Lint Skipped

Unit

Test Failures

Branch

rust-option

Build Status

Buildable 5995
Build 6277: arc lint + arc unit

Unit TestsBroken
View All

	Time	Test
	0 ms	/datacube/dereckson/dev/nasqueron/keruald/keruald/omnitools/tests/DataTypes/Result/OkTest.php sh: line 1: phpunit: command not found
	0 ms	/datacube/dereckson/dev/nasqueron/keruald/keruald/omnitools/tests/Reflection/TypeTest.php sh: line 1: phpunit: command not found

Event Timeline

dereckson requested review of this revision.Sun, Oct 12, 13:14

dereckson created this revision.

Harbormaster completed remote builds in B5995: Diff 9673.Sun, Oct 12, 13:14

$ arc unit                                              
   PASS    2ms★  Keruald.OmniTools.Tests.Reflection.TypeTest.testGetTypeOf with data set #0
   PASS   <1ms★  Keruald.OmniTools.Tests.Reflection.TypeTest.testGetTypeOf with data set #1
   PASS   <1ms★  Keruald.OmniTools.Tests.Reflection.TypeTest.testGetTypeOf with data set #2
   PASS    5ms★  Keruald.OmniTools.Tests.DataTypes.Result.OkTest.testIsOk
   PASS   <1ms★  Keruald.OmniTools.Tests.DataTypes.Result.OkTest.testIsError
   PASS   <1ms★  Keruald.OmniTools.Tests.DataTypes.Result.OkTest.testGetValue
   PASS   <1ms★  Keruald.OmniTools.Tests.DataTypes.Result.OkTest.testSetValue
   PASS   <1ms★  Keruald.OmniTools.Tests.DataTypes.Result.OkTest.testSetValueWhenTypeIsMutated
   PASS   <1ms★  Keruald.OmniTools.Tests.DataTypes.Result.OkTest.testMap
   PASS   <1ms★  Keruald.OmniTools.Tests.DataTypes.Result.OkTest.testMapErr
   PASS   <1ms★  Keruald.OmniTools.Tests.DataTypes.Result.OkTest.testOrElse