Page MenuHomeDevCentral

Documentation for the image
ClosedPublic

Authored by dereckson on Nov 9 2015, 18:38.
Referenced Files
F3918044: D40.diff
Fri, Dec 20, 05:33
Unknown Object (File)
Tue, Dec 17, 12:25
Unknown Object (File)
Fri, Dec 13, 23:51
Unknown Object (File)
Fri, Dec 13, 13:20
Unknown Object (File)
Fri, Dec 13, 08:25
Unknown Object (File)
Fri, Dec 13, 06:57
Unknown Object (File)
Fri, Dec 13, 05:09
Unknown Object (File)
Thu, Dec 12, 21:49
Subscribers
None

Details

Summary

README.md to offer some pointers about the image content or how to use it

Test Plan

proofreading

Diff Detail

Repository
rDPHAB Docker image for Phabricator
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
D40
Build Status
Buildable 33
Build 33: arc lint + arc unit

Event Timeline

dereckson retitled this revision from to Documentation for the image.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: Sandlayth.

Will be squashed in one commit when merged on master.

Sandlayth edited reviewers, added: dereckson; removed: Sandlayth.

Add links to containers and informations about '-e' option

dereckson edited reviewers, added: Sandlayth; removed: dereckson.
  • Rewritten -e notes, list of the environment variables
  • Arcanist container is now ready
  • Instructions about how to configure Aphlict in Phabricator config
  • Questions in bold in Troubleshoot question
  • Acknowledgement and Team sections
dereckson added inline comments.
README.md
73

extraneous space

dereckson marked an inline comment as done.
  • Whitespace issues
  • One question previously left half unanswered
dereckson added inline comments.
README.md
158

double space

dereckson requested a review of this revision.Nov 12 2015, 17:31
dereckson marked an inline comment as done.
dereckson added inline comments.
README.md
158

Mistaken seen the _ as a whitespace.

Sandlayth edited reviewers, added: dereckson; removed: Sandlayth.
Sandlayth marked an inline comment as done.

Remove some extra whitespaces.

dereckson edited reviewers, added: Sandlayth; removed: dereckson.
dereckson added inline comments.
README.md
30

To be coherent with other steps, a whiteline should be added there too.

At the blank line circus, we like to push around \n like lions.

Sandlayth edited edge metadata.
This revision is now accepted and ready to land.Nov 13 2015, 19:31
This revision was automatically updated to reflect the committed changes.