Differential D3775

Import database unit tests from Obsidian Workspaces
ClosedPublic
Actions

Authored by dereckson on Sun, Oct 19, 15:20.

Tags

None

Referenced Files

	F12295611: D3775.id9777.diff
	Mon, Oct 20, 06:02

	F12295609: D3775.id9779.diff
	Mon, Oct 20, 06:02

	F12295532: D3775.id9778.diff
	Mon, Oct 20, 05:45

	F12294669: D3775.diff
	Mon, Oct 20, 02:24

Subscribers

None

Details

Reviewers

Commits

rKDB2169cf7700e1: Import database unit tests from Obsidian Workspaces
rKERUALD5e492da098f5: Import database unit tests from Obsidian Workspaces

Summary

Also import DatabaseException::getQuery() as SqlException::getQuery().

Diff Detail

Repository

rKERUALD Keruald libraries development repository

Lint

Lint Errors

Severity	Location	Code	Message
Error	database/tests/Engines/MySQLiEngineTest.php:186	PHPCS.E.Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine	Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine
Error	database/tests/Exceptions/SqlExceptionTest.php:27	PHPCS.E.Generic.Files.LineLength.MaxExceeded	Generic.Files.LineLength.MaxExceeded

Unit

Tests Passed

Branch

consolidate-with-obsidian-tests

Build Status

Buildable 6044
Build 6328: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Sun, Oct 19, 15:20

dereckson created this revision.

Harbormaster completed remote builds in B6044: Diff 9777.Sun, Oct 19, 15:20

testEscape method signature

Harbormaster completed remote builds in B6045: Diff 9778.Sun, Oct 19, 15:23

dereckson accepted this revision.Sun, Oct 19, 15:24

dereckson edited the summary of this revision. (Show Details)

This revision is now accepted and ready to land.Sun, Oct 19, 15:24

This revision was landed with ongoing or failed builds.Sun, Oct 19, 15:25

Closed by commit rKERUALD5e492da098f5: Import database unit tests from Obsidian Workspaces (authored by dereckson). · Explain Why

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKERUALD5e492da098f5: Import database unit tests from Obsidian Workspaces.

dereckson added a commit: rKDB2169cf7700e1: Import database unit tests from Obsidian Workspaces.

dereckson mentioned this in D3774: Switch events and databases classes to Keruald packages implementations.Sun, Oct 19, 15:34

Revision Contents
Changeset List

Path

Size

2 lines

database/

src/

Exceptions/

SqlException.php

8 lines

tests/

Engines/

MySQLiEngineTest.php

20 lines

Exceptions/

SqlExceptionTest.php

31 lines

Diff 9777

composer.json

Loading...

database/src/Exceptions/SqlException.php

Loading...

database/tests/Engines/MySQLiEngineTest.php

Loading...

database/tests/Exceptions/SqlExceptionTest.php

Loading...