Support PDO PostgreSQL
AcceptedPublic
Actions

Authored by dereckson on Thu, Oct 23, 00:41.

Details

Reviewers

dereckson

Summary

Allow to query PostgreSQL databases through PDO.

Support has been added for both PHP 8.4+ Pdo\Pgsql
and previous versions PDO class.

Use case: Orbeon Forms store data in a PostgreSQL database,
an application for Obsidian Workspaces is planned to read forms
and annotate them into an Obsidian collection.

Test Plan

Unit tests provided for both PDO PostgreSQL engines

Diff Detail

Repository

rKERUALD Keruald libraries development repository

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	database/src/Result/PDODatabaseResult.php:40	PHPCS.W.Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition	Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition

Unit

Test Failures

Branch

pdo-postgresql

Build Status

Buildable 6085
Build 6369: arc lint + arc unit

Unit TestsBroken
View All

	Time	Test
	10 ms	Keruald.Database.Tests.Engines.PostgreSQLPDOEngineTest.testNextId Keruald\Database\Tests\Engines\PostgreSQLPDOEngineTest::testNextId Keruald\Database\Exceptions\SqlException: ERROR: duplicate key value violates unique constraint "numbers_pkey" DETAIL: Key (id)=(1700) already exists.
	3 ms	Keruald.Database.Tests.Engines.PgsqlPDOEngineTest.testArrayShapeForFetchRow
	3 ms	Keruald.Database.Tests.Engines.PgsqlPDOEngineTest.testEscapeIdentifier with data set "No special escape for apostrophe"
	3 ms	Keruald.Database.Tests.Engines.PgsqlPDOEngineTest.testEscapeIdentifier with data set "Regular name"
	3 ms	Keruald.Database.Tests.Engines.PgsqlPDOEngineTest.testEscapeIdentifier with data set "Reserved keyword"
		View Full Test Results (1 Broken · 30 Passed)

Event Timeline

dereckson requested review of this revision.Thu, Oct 23, 00:41

dereckson created this revision.

Harbormaster completed remote builds in B6084: Diff 9850.Thu, Oct 23, 00:41

dereckson added inline comments.Thu, Oct 23, 00:46

database/src/Result/PDODatabaseResult.php
41	Rust loop construct would be handy here. We could rewrite like this, but I doubt it's easier to read: while(true) { $row = $this->fetchRow(); if ($row === null) { break; } yield $row; }

Re-run unit tests

Harbormaster completed remote builds in B6085: Diff 9851.Thu, Oct 23, 00:47

This is strange for the tests:

when run with arc unit, tests pass
when run from PhpStorm, tests pass
when run directly calling phpunit at monorepo root, tests pass
when run from databases/ at library root, tests pass

I don't know what arc diff does as race condition, but test restarts both the table AND the sequence from scratch:

BasePDOPostgreSQLTestCase::testNextId

$this->db->query("TRUNCATE numbers RESTART IDENTITY");
$this->db->query("INSERT INTO numbers (id, number) VALUES (1700, 42742)");

If we truncate the table, it should be non-existing.

We could harden the code for a transaction, but I really suspect arc diff to run tests twice in //.

$ phpunit         
Switching to Composer phpunit:
PHPUnit 10.5.58 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.4.13
Configuration: /datacube/dereckson/dev/nasqueron/keruald/keruald/database/phpunit.xml

................................................................. 65 / 88 ( 73%)
.......................                                           88 / 88 (100%)

Time: 00:03.486, Memory: 4.00 MB

OK (88 tests, 104 assertions)