Details

Reviewers

Commits

rKDB17c68efa8844: Support PDO PostgreSQL
rKERUALD2c856afe0202: Support PDO PostgreSQL

Summary

Allow to query PostgreSQL databases through PDO.

Support has been added for both PHP 8.4+ Pdo\Pgsql
and previous versions PDO class.

Use case: Orbeon Forms store data in a PostgreSQL database,
an application for Obsidian Workspaces is planned to read forms
and annotate them into an Obsidian collection.

Test Plan

Unit tests provided for both PDO PostgreSQL engines

Diff Detail

Repository

rKERUALD Keruald libraries development repository

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	database/src/Result/PDODatabaseResult.php:40	PHPCS.W.Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition	Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition

Unit

Tests Passed

Branch

pdo-postgresql

Build Status

Buildable 6087
Build 6371: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Thu, Oct 23, 00:41

dereckson created this revision.

Harbormaster completed remote builds in B6084: Diff 9850.Thu, Oct 23, 00:41

dereckson added inline comments.Thu, Oct 23, 00:46

database/src/Result/PDODatabaseResult.php
41	Rust loop construct would be handy here. We could rewrite like this, but I doubt it's easier to read: while(true) { $row = $this->fetchRow(); if ($row === null) { break; } yield $row; }

Re-run unit tests

Harbormaster completed remote builds in B6085: Diff 9851.Thu, Oct 23, 00:47

This is strange for the tests:

when run with arc unit, tests pass
when run from PhpStorm, tests pass
when run directly calling phpunit at monorepo root, tests pass
when run from databases/ at library root, tests pass

I don't know what arc diff does as race condition, but test restarts both the table AND the sequence from scratch:

BasePDOPostgreSQLTestCase::testNextId

$this->db->query("TRUNCATE numbers RESTART IDENTITY");
$this->db->query("INSERT INTO numbers (id, number) VALUES (1700, 42742)");

If we truncate the table, it should be non-existing.

We could harden the code for a transaction, but I really suspect arc diff to run tests twice in //.

$ phpunit         
Switching to Composer phpunit:
PHPUnit 10.5.58 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.4.13
Configuration: /datacube/dereckson/dev/nasqueron/keruald/keruald/database/phpunit.xml

................................................................. 65 / 88 ( 73%)
.......................                                           88 / 88 (100%)

Time: 00:03.486, Memory: 4.00 MB

OK (88 tests, 104 assertions)

Transaction so arc diff can run PgsqlPDOEngineTest and PostgreSQLPDOEngineTest in //

Harbormaster completed remote builds in B6086: Diff 9852.Thu, Oct 23, 00:59

dereckson accepted this revision.Thu, Oct 23, 01:00

This revision is now accepted and ready to land.Thu, Oct 23, 01:00

Bump version and document PostgreSQL drivers in the README

Harbormaster completed remote builds in B6087: Diff 9853.Thu, Oct 23, 19:39

dereckson accepted this revision.Thu, Oct 23, 19:39

This revision was landed with ongoing or failed builds.Thu, Oct 23, 19:40

Closed by commit rKERUALD2c856afe0202: Support PDO PostgreSQL (authored by dereckson). · Explain Why

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKERUALD2c856afe0202: Support PDO PostgreSQL.

dereckson added a commit: rKDB17c68efa8844: Support PDO PostgreSQL.Thu, Oct 23, 20:52

Support PDO PostgreSQL
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 9853

composer.json

database/README.md

database/src/Engines/PDOEngine.php

database/src/Engines/PgsqlPDOEngine.php

database/src/Engines/PostgreSQLPDOEngine.php

database/src/Engines/WithPDOPostgreSQL.php

database/src/Exceptions/NotImplementedException.php

database/src/Result/PDODatabaseResult.php

database/tests/Engines/BasePDOPostgreSQLTestCase.php

database/tests/Engines/BasePDOTestCase.php

database/tests/Engines/PgsqlPDOEngineTest.php

database/tests/Engines/PostgreSQLPDOEngineTest.php

database/tests/data/postgresql.sql

Support PDO PostgreSQLClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 9853

composer.json

database/README.md

database/src/Engines/PDOEngine.php

database/src/Engines/PgsqlPDOEngine.php

database/src/Engines/PostgreSQLPDOEngine.php

database/src/Engines/WithPDOPostgreSQL.php

database/src/Exceptions/NotImplementedException.php

database/src/Result/PDODatabaseResult.php

database/tests/Engines/BasePDOPostgreSQLTestCase.php

database/tests/Engines/BasePDOTestCase.php

database/tests/Engines/PgsqlPDOEngineTest.php

database/tests/Engines/PostgreSQLPDOEngineTest.php

database/tests/data/postgresql.sql

Support PDO PostgreSQL
ClosedPublic
Actions

Revision Contents
Changeset List