Page MenuHomeDevCentral
Differential D3827

Modernize ApplicationConfiguration
ClosedPublic
Actions

Authored by dereckson on Oct 29 2025, 22:59.
Tags
None
Referenced Files
F20232138: D3827.diff
Tue, Jan 6, 19:17
Unknown Object (File)
Mon, Jan 5, 11:23
Unknown Object (File)
Sun, Jan 4, 09:48
Unknown Object (File)
Fri, Jan 2, 01:42
Unknown Object (File)
Mon, Dec 29, 03:55
Unknown Object (File)
Mon, Dec 29, 03:14
Unknown Object (File)
Mon, Dec 29, 02:53
Unknown Object (File)
Mon, Dec 29, 02:52
View All 89 Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rOBSIDIAN330f740251a9: Modernize ApplicationConfiguration
Summary

Add types to properties

Add property $name explicitly

This fixes the following issue:
PHP Deprecated:
Creation of dynamic property ApplicationConfiguration::$name is deprecated
in /var/51-wwwroot/obsidian/workspaces/src/Engines/Apps/ApplicationConfiguration.php on line 66

Following style conventions for class end

Diff Detail

Repository
rOBSIDIAN Obsidian Workspaces
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
main
Build Status
Buildable 6116
Build 6400: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Oct 29 2025, 22:59
dereckson created this revision.
Harbormaster completed remote builds in B6116: Diff 9911.Oct 29 2025, 22:59
dereckson accepted this revision.Oct 29 2025, 22:59
This revision is now accepted and ready to land.Oct 29 2025, 22:59
Closed by commit rOBSIDIAN330f740251a9: Modernize ApplicationConfiguration (authored by dereckson). · Explain WhyOct 29 2025, 23:00
This revision was automatically updated to reflect the committed changes.
dereckson added a commit: rOBSIDIAN330f740251a9: Modernize ApplicationConfiguration.

Revision Contents
Changeset List

PathSize
workspaces/
src/
Engines/
Apps/
24 lines

Diff 9911

View Options

workspaces/src/Engines/Apps/ApplicationConfiguration.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator