Page MenuHomeDevCentral

Move resolve_resource_id into Resources helper class
ClosedPublic

Authored by dereckson on Tue, Nov 4, 02:15.
Tags
None
Referenced Files
F12504839: D3846.id9972.diff
Sat, Nov 8, 20:01
F12503588: D3846.id9971.diff
Sat, Nov 8, 18:45
F12503097: D3846.id.diff
Sat, Nov 8, 18:11
F12502111: D3846.id9960.diff
Sat, Nov 8, 17:11
Unknown Object (File)
Sat, Nov 8, 01:05
Unknown Object (File)
Fri, Nov 7, 19:51
Unknown Object (File)
Fri, Nov 7, 12:26
Unknown Object (File)
Fri, Nov 7, 12:22
Subscribers
None

Details

Summary

Recreate the missing or prune get_user_id method

Test Plan
  • browse a regular namespace
  • load a workspace with custom auth method

Diff Detail

Repository
rOBSIDIAN Obsidian Workspaces
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
main
Build Status
Buildable 6143
Build 6427: arc lint + arc unit

Event Timeline

dereckson added inline comments.
workspaces/src/includes/objects/user.php
263

There is an implementation issue for Option::orElse

We should ideally have:

  • Option::or to give a default value
  • Option::orElse to execute a closure in lazy loading

Here, the _from_email will always be executed, to get the default value to pass to orElse

Our code could become:

->orElse(function() use ($expression) {
    return self::get_user_from_email($expression);
})

In Keruald, this None::orElse must method actually match or():

public function orElse (mixed $default) : mixed {
    return $default;
}

It should execute the function, while in Some, the implementation is correct:

public function orElse (callable $callable) : mixed {
    return $callable()
}

Option::orElse is correctly implemented in D3847.

Bump omnitools to dev 1.x version. Use camel case.

This revision is now accepted and ready to land.Thu, Nov 6, 00:11