Change Details

This commit allows us to consider this code base to be PHP 7. To explicitely declare return type and non object parameters allow us to be sure code documentation is up to date and tell the truth, and to allow to detect regression immediately in the future. That improves codebase quality. Fixes T1062. Phabricator is explicitely left alone, as we need to refactor this part of the code. # and test coverage isn't optimal. #

This commit allows us to consider this code base to be PHP 7. To explicitly declare return type and non object parameters allow us to be sure code documentation is up to date and tell the truth, and to allow to detect regression immediately in the future. That improves codebase quality. Phabricator is currently left alone, as we need to refactor this part of the code. We'll add return type as part of the refactoring. Fixes T1062.

This commit allows us to consider this code base to be PHP 7. To explicitely declare return type and non object parameters allow us to be sure code documentation is up to date and tell the truth, and to allow to detect regression immediately in the future. That improves codebase quality. Fixes T1062. Phabricator is explicitecurrently left alone, as we need to refactor this part of the code. # and test coverage isn't optimal.this part of the code. We'll add return type as part of the #refactoring. Fixes T1062.