Page MenuHomeDevCentral

Declare explicitely return types
ClosedPublic

Authored by dereckson on Dec 31 2016, 21:44.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 15:24
Unknown Object (File)
Tue, Nov 12, 04:40
Unknown Object (File)
Sat, Nov 9, 14:42
Unknown Object (File)
Mon, Oct 28, 09:37
Unknown Object (File)
Mon, Oct 28, 07:26
Unknown Object (File)
Oct 1 2024, 07:55
Unknown Object (File)
Oct 1 2024, 07:55
Unknown Object (File)
Oct 1 2024, 07:32
Subscribers

Details

Summary

This commit allows us to consider this code base to be PHP 7.

To explicitly declare return type and non object parameters
allow us to be sure code documentation is up to date and tell
the truth, and to allow to detect regression immediately in
the future. That improves codebase quality.

Phabricator is currently left alone, as we need to refactor
this part of the code. We'll add return type as part of the
refactoring.

Fixes T1062.

Test Plan

The code touched is the part of code base with full code coverage.
Tests was run at each iteration to detect type issues.

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson edited edge metadata.
This revision is now accepted and ready to land.Dec 31 2016, 21:50
This revision was automatically updated to reflect the committed changes.