Page MenuHomeDevCentral
Differential D1016

Disable reload capability for Odderon
ClosedPublic
Actions

Authored by dereckson on Sep 14 2017, 23:54.
Tags
None
Referenced Files
F3745879: D1016.diff
Fri, Nov 15, 17:29
Unknown Object (File)
Wed, Nov 13, 10:37
Unknown Object (File)
Mon, Nov 11, 01:30
Unknown Object (File)
Sat, Nov 9, 16:02
Unknown Object (File)
Sun, Nov 3, 18:42
Unknown Object (File)
Sun, Oct 27, 10:31
Unknown Object (File)
Sat, Oct 26, 06:19
Unknown Object (File)
Tue, Oct 22, 07:43
View All Files
Subscribers
None

Details

Reviewers
dereckson
Maniphest Tasks
T1233: Odderon systemd service doesn't start anymore
Commits
rOPSe630b660667a: Disable reload capability for Odderon
Summary

Darkbot latest source code doesn't populate a pid file,
and this isn't really useful:

  • to kill the process, systemd knows the pid as it's a non forking process
  • we never used reload through systemd

Fixes T1233.

Test Plan

systemctl status odderon

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Passed
Unit
No Test Coverage
Branch
remove-darkbot-reload (branched from master)
Build Status
Buildable 1590
Build 1838: arc lint + arc unit

Event Timeline

dereckson created this revision.Sep 14 2017, 23:54
dereckson mentioned this in D1015: Set absolute path for systemd Exec instruction.Sep 14 2017, 23:54
dereckson retitled this revision from Disable reload capability for Odderon Darkbot latest source code doesn't populate a pid file, and this isn't really useful: - to kill the process, systemd knows the pid as it's a non forking process - we never used reload through systemd to Disable reload capability for Odderon.
dereckson edited the summary of this revision. (Show Details)
dereckson edited the test plan for this revision. (Show Details)
dereckson accepted this revision.Sep 15 2017, 17:44
This revision is now accepted and ready to land.Sep 15 2017, 17:44
Closed by commit rOPSe630b660667a: Disable reload capability for Odderon (authored by dereckson, committed by dereckson). · Explain WhySep 15 2017, 17:45
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
roles/
shellserver/
odderon/
files/
2 lines

Diff 2589

View Options

roles/shellserver/odderon/files/odderon.service

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator