Page MenuHomeDevCentral

Allow URL video parsing when a warning is triggered by youtube-dl
ClosedPublic

Authored by dereckson on Sep 16 2017, 16:45.

Details

Summary

Currently, when a video URL is given on a channel with the parse-url
flag enabled, youtube-dl is called to resolve video URLS for video
domains.

If any output reaches stderr, exec throws an error, intercepted
by the catch block, and nothing happens.

Fixes T1234.

Thanks to @xcombelle to have suggested the use of --no-warning flag.

Test Plan

url:getvideotitle https://www.youtube.com/watch?v=4CXOb0Oubxo

Diff Detail

Repository
rVIPER ViperServ scripts
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dereckson created this revision.Sep 16 2017, 16:45
xcombelle requested changes to this revision.Sep 16 2017, 17:06
xcombelle added inline comments.
Daeghrefn/Channel.tcl
26

the correct syntax is youtube-dl -e --no-warnings $url note the s at the end of no-warnings

This revision now requires changes to proceed.Sep 16 2017, 17:06
dereckson updated this revision to Diff 2596.Sep 16 2017, 17:44
dereckson edited edge metadata.

Fix argument

dereckson marked an inline comment as done.Sep 16 2017, 17:45
xcombelle accepted this revision.Sep 16 2017, 18:01
This revision is now accepted and ready to land.Sep 16 2017, 18:01
This revision was automatically updated to reflect the committed changes.