Page MenuHomeDevCentral
Differential D1017

Allow URL video parsing when a warning is triggered by youtube-dl
ClosedPublic
Actions

Authored by dereckson on Sep 16 2017, 16:45.
Tags
None
Referenced Files
F3763413: D1017.diff
Thu, Nov 21, 23:29
Unknown Object (File)
Tue, Nov 19, 06:34
Unknown Object (File)
Thu, Nov 14, 09:07
Unknown Object (File)
Tue, Nov 12, 12:46
Unknown Object (File)
Mon, Nov 11, 23:16
Unknown Object (File)
Fri, Nov 8, 22:30
Unknown Object (File)
Mon, Nov 4, 05:21
Unknown Object (File)
Sun, Nov 3, 02:05
View All Files
Subscribers
xcombelle

Details

Reviewers
xcombelle
Maniphest Tasks
T1234: Video URLs aren't shown on #fauve anymore
Commits
rVIPER440008349221: Allow URL video parsing when a warning is triggered by youtube-dl
Summary

Currently, when a video URL is given on a channel with the parse-url
flag enabled, youtube-dl is called to resolve video URLS for video
domains.

If any output reaches stderr, exec throws an error, intercepted
by the catch block, and nothing happens.

Fixes T1234.

Thanks to @xcombelle to have suggested the use of --no-warning flag.

Test Plan

url:getvideotitle https://www.youtube.com/watch?v=4CXOb0Oubxo

Diff Detail

Repository
rVIPER ViperServ scripts
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
youtube-dl (branched from master)
Build Status
Buildable 1593
Build 1841: arc lint + arc unit

Event Timeline

dereckson created this revision.Sep 16 2017, 16:45
xcombelle requested changes to this revision.Sep 16 2017, 17:06
xcombelle added inline comments.
Daeghrefn/Channel.tcl
26

the correct syntax is youtube-dl -e --no-warnings $url note the s at the end of no-warnings

This revision now requires changes to proceed.Sep 16 2017, 17:06
dereckson updated this revision to Diff 2596.Sep 16 2017, 17:44
dereckson edited edge metadata.

Fix argument

dereckson marked an inline comment as done.Sep 16 2017, 17:45
xcombelle accepted this revision.Sep 16 2017, 18:01
This revision is now accepted and ready to land.Sep 16 2017, 18:01
Closed by commit rVIPER440008349221: Allow URL video parsing when a warning is triggered by youtube-dl (authored by dereckson, committed by dereckson). · Explain WhySep 18 2017, 10:04
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
Daeghrefn/
2 lines

Diff 2595

View Options

Daeghrefn/Channel.tcl

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator