Page MenuHomeDevCentral

Set Twitter message length
ClosedPublic

Authored by dereckson on Oct 12 2017, 16:12.

Details

Summary

This change prepares for https://www.theverge.com/2017/9/26/16363912/twitter-character-limit-increase-280-test

Currently, the API refuses statuses > 140 characters, so we can't set it to 280.

Ref T1249.

Test Plan

Fire a longer message than 140 characters.

Diff Detail

Repository
rVIPER ViperServ scripts
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dereckson created this revision.Oct 12 2017, 16:12
dereckson accepted this revision.Oct 13 2017, 22:34
This revision is now accepted and ready to land.Oct 13 2017, 22:34
dereckson planned changes to this revision.Oct 13 2017, 22:39

Get rid of the global variable, so we can use .s to load it.

dereckson updated this revision to Diff 2694.Oct 13 2017, 22:41

Get rid of the global variable.

This revision is now accepted and ready to land.Oct 13 2017, 22:41
dereckson updated this revision to Diff 2695.Oct 13 2017, 22:43

s/twittter/twitter

dereckson resigned from this revision.Oct 14 2017, 00:07

The 280 limit is for web only:

2:40:41 <Daeghrefn> [DEBUG] Twitter error: OAuth failure: (code: 403) {"errors":[{"code":186,"message":"Status is over 140 characters."}]}
22:41:07 <Dereckson> .tcl putdebug
22:41:07 <Daeghrefn> [DEBUG] OAuth failure: (code: 403) {"errors":[{"code":186,"message":"Status is over 140 characters."}]}
22:41:07 <Daeghrefn>     while executing
22:41:07 <Daeghrefn> "error "OAuth failure: (code: $ncode) $data""
22:41:07 <Daeghrefn>     (procedure "oauth::query" line 16)
22:41:07 <Daeghrefn>     invoked from within
22:41:07 <Daeghrefn> "oauth::query $url $method $oauth_header $oauth_query"
22:41:07 <Daeghrefn>     (procedure "oauth::query_call" line 25)
22:41:07 <Daeghrefn>     invoked from within
22:41:07 <Daeghrefn> "oauth::query_call $url $consumer_key $consumer_secret $method $params $query_dict $oauth_token_secret"
22:41:07 <Daeghrefn>     (procedure "oauth::query_api" line 3)
22:41:07 <Daeghrefn>     invoked from within
22:41:07 <Daeghrefn> "oauth::query_api $url {*}[registry get twitter.oauth.consumer] $method {*}$token $query_list"
22:41:07 <Daeghrefn>     (procedure "twitter_query" line 20)
22:41:07 <Daeghrefn>     invoked from within
22:41:07 <Daeghrefn> "twitter_query $status_url $account [list status $message]"
This revision now requires review to proceed.Oct 14 2017, 00:07
dereckson abandoned this revision.Oct 14 2017, 00:07
dereckson reclaimed this revision.Oct 14 2017, 22:54

We can land this with 140 as current setting actually.

dereckson updated this revision to Diff 2696.Oct 14 2017, 22:55

Set to 140

dereckson retitled this revision from Set Twitter message length to 280 to Set Twitter message length.Oct 14 2017, 22:56
dereckson edited the summary of this revision. (Show Details)
dereckson accepted this revision.Oct 14 2017, 23:01

Works with https://twitter.com/Ideedarticles/status/919336799654342657 (and blocked a 249 characters message).

This revision is now accepted and ready to land.Oct 14 2017, 23:01
This revision was automatically updated to reflect the committed changes.