Page MenuHomeDevCentral
Differential D1066

Improve documentation and casting types
ClosedPublic
Actions

Authored by dereckson on Oct 17 2017, 20:10.
Tags
None
Referenced Files
F27682314: D1066.diff
Wed, May 6, 20:42
Unknown Object (File)
Sun, May 3, 07:05
Unknown Object (File)
Thu, Apr 30, 13:38
Unknown Object (File)
Wed, Apr 29, 07:49
Unknown Object (File)
Sun, Apr 26, 13:37
Unknown Object (File)
Mon, Apr 20, 01:53
Unknown Object (File)
Wed, Apr 15, 17:08
Unknown Object (File)
Fri, Apr 10, 16:55
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rNOTIF9cd8a8a6e913: Improve documentation and casting types
Summary

Fix type mismatches between docblocks and signatures.

Test Plan
$ phan | grep PhanTypeMismatchDeclaredParam
$ phan | grep PhanTypeMismatchDeclaredReturn
$ phan | grep PhanTypeMismatchProperty
$ phan | grep PhanTypeMismatchArgument
$ phan | grep PhanCommentParamOnEmptyParamList

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
Tests Passed
Branch
doc-types
Build Status
Buildable 1681
Build 1929: arc lint + arc unit

Event Timeline

dereckson created this revision.Oct 17 2017, 20:10
Harbormaster completed remote builds in B1681: Diff 2728.Oct 17 2017, 20:10
dereckson retitled this revision from Improve documentation types to Improve documentation and casting types.Oct 17 2017, 20:45
dereckson edited the test plan for this revision. (Show Details)
dereckson updated this revision to Diff 2729.Oct 17 2017, 20:46

More fixes.

Harbormaster completed remote builds in B1682: Diff 2729.Oct 17 2017, 20:46
dereckson accepted this revision.Oct 17 2017, 20:50
This revision is now accepted and ready to land.Oct 17 2017, 20:50
Closed by commit rNOTIF9cd8a8a6e913: Improve documentation and casting types (authored by dereckson). · Explain WhyOct 17 2017, 20:51
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
app/
Actions/
2 lines
Events/
2 lines
Listeners/
2 lines
Phabricator/
4 lines

Diff 2728

View Options

app/Actions/ActionError.php

Loading...
View Options

app/Events/ReportEvent.php

Loading...
View Options

app/Listeners/AMQPEventListener.php

Loading...
View Options

app/Phabricator/ProjectsMap.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator