Page MenuHomeDevCentral

Better Phabricator API requests handling
ClosedPublic

Authored by dereckson on Dec 25 2015, 19:45.
Tags
None
Referenced Files
F3751650: D120.diff
Sun, Nov 17, 11:26
Unknown Object (File)
Wed, Nov 13, 05:55
Unknown Object (File)
Thu, Nov 7, 10:43
Unknown Object (File)
Thu, Nov 7, 10:30
Unknown Object (File)
Fri, Nov 1, 15:38
Unknown Object (File)
Sun, Oct 27, 04:35
Unknown Object (File)
Oct 13 2024, 20:10
Unknown Object (File)
Oct 12 2024, 15:55
Subscribers
None

Details

Reviewers
dereckson
Commits
Unknown Object (Diffusion Commit)
rNOTIF06d52a204908: Better Phabricator API requests handling
Summary

We don't try to guess if the API reply will be an object with the
PHID as key, or an array with 0 as offset for our reply, or an object
with 0 as property.

Instead, we call PhabricatorAPI::getFirstResult() method.

Test Plan

With this change, the development server fired notifications
for pending requests.

19:42:09 < Wearg> dereckson accepted D117: PHPMD: composer phpmd.

Diff Detail

Repository
rNOTIF Notifications center
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
save-payload
Build Status
Buildable 145
Build 145: arc lint + arc unit

Event Timeline

dereckson retitled this revision from to Better Phabricator API requests handling.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson edited edge metadata.
This revision is now accepted and ready to land.Dec 25 2015, 19:47
This revision was automatically updated to reflect the committed changes.