Page MenuHomeDevCentral

Refactor Phabricator event and last payload save code
ClosedPublic

Authored by dereckson on Dec 25 2015, 19:53.
Tags
None
Referenced Files
F9793814: D122.diff
Sat, Jun 14, 07:47
Unknown Object (File)
Wed, Jun 11, 18:37
Unknown Object (File)
Fri, May 23, 10:25
Unknown Object (File)
Thu, May 22, 21:10
Unknown Object (File)
Thu, May 22, 08:50
Unknown Object (File)
Wed, May 21, 13:34
Unknown Object (File)
Wed, May 21, 03:03
Unknown Object (File)
Tue, May 20, 08:19
Subscribers
None

Details

Summary

The Phabricator event now uses a payload property like the others
...PayloadEvent classes, and is now responsible to initialize
an instance of PhabricatorStory itself.

With a payload property, we are now able to use LastPayloadSaver
for all our payload events.

Test Plan
  • Wait a Phabricator request, check storage/logs/payload.json
  • Same for a GitHub or Docker Hub request

Diff Detail

Repository
rNOTIF Notifications center
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
save-payload
Build Status
Buildable 147
Build 147: arc lint + arc unit

Event Timeline

dereckson retitled this revision from to Refactor Phabricator event and last payload save code.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson edited edge metadata.
This revision is now accepted and ready to land.Dec 25 2015, 19:54
This revision was automatically updated to reflect the committed changes.