Differential D1262

Sort jails.flatlist output by alphabetical order
ClosedPublic
Actions

Authored by dereckson on Nov 24 2017, 04:50.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 17, 21:08

	Unknown Object (File)
	Mon, Nov 11, 05:54

	Unknown Object (File)
	Sun, Nov 10, 05:46

	Unknown Object (File)
	Sun, Nov 10, 04:21

	Unknown Object (File)
	Sat, Nov 9, 16:04

	Unknown Object (File)
	Sat, Nov 9, 15:45

	Unknown Object (File)
	Tue, Nov 5, 21:02

	Unknown Object (File)
	Mon, Oct 28, 15:22

Subscribers

None

Details

Reviewers

Commits

rOPS0aa11e4fecf4: Sort jails.flatlist output by alphabetical order

Summary

This issue make unit test fails on Python 2
(works on Python 3 but currently _modules/ use Python 2 .iteritems()).

This is a follow-up for cd3273b0.

Test Plan

This fixes the following test issue:

======================================================================
FAIL: test_flatlist (test_jails.Testinstance)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/home/dereckson/dev/nasqueron/ops/repo/_tests/modules/test_jails.py", line 36, in test_flatlist
    self.assertEqual("guest1 guest2", jails.flatlist())
AssertionError: 'guest1 guest2' != 'guest2 guest1'

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Passed

Unit

No Test Coverage

Branch

sort-test-list-output (branched from master)

Build Status

Buildable 2006
Build 2254: arc lint + arc unit

Event Timeline

dereckson created this revision.Nov 24 2017, 04:50

Harbormaster completed remote builds in B2006: Diff 3244.Nov 24 2017, 04:50

dereckson edited the summary of this revision. (Show Details)Nov 24 2017, 04:51

Closed by commit rOPS0aa11e4fecf4: Sort jails.flatlist output by alphabetical order (authored by dereckson). · Explain WhyNov 24 2017, 04:51

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

_modules/

2 lines

Diff 3244

_modules/jails.py

Loading...