Replace object return value by class type
ClosedPublic
Actions

Authored by dereckson on Feb 16 2018, 15:43.

Tags

None

Referenced Files

	F24098779: D1308.id3357.diff
	Mon, Feb 9, 19:49

	F24084130: D1308.id3357.diff
	Mon, Feb 9, 10:09

	Unknown Object (File)
	Sun, Feb 8, 15:53

	Unknown Object (File)
	Sun, Feb 8, 15:53

	Unknown Object (File)
	Sun, Feb 8, 15:38

	Unknown Object (File)
	Sun, Feb 8, 14:04

	Unknown Object (File)
	Sun, Feb 8, 14:04

	Unknown Object (File)
	Sun, Feb 8, 10:47

View All Files

Subscribers

None

Details

Reviewers

dereckson

Maniphest Tasks

T1335: Make API servers log compatible with PHP 7.1 and not only PHP 7.2

Commits

rAPISRVLOGSdc3de75449c0: Replace object return value by class type

Summary

This code was 7.2 compatible, but not 7.1, without real benefit,
as it used https://wiki.php.net/rfc/object-typehint.

Fixes T1335.

Test Plan

Test under PHP 7.1.

Diff Detail

Repository

rAPISRVLOGS Servers log :: Add new entries API

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

drop-object-typehint (branched from master)

Build Status

Buildable 2068
Build 2316: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Feb 16 2018, 15:43

dereckson created this revision.

Harbormaster completed remote builds in B2068: Diff 3356.Feb 16 2018, 15:43

dereckson requested review of this revision.Feb 16 2018, 15:43

dereckson accepted this revision.Feb 16 2018, 15:43

This revision is now accepted and ready to land.Feb 16 2018, 15:43

Closed by commit rAPISRVLOGSdc3de75449c0: Replace object return value by class type (authored by dereckson). · Explain WhyFeb 16 2018, 15:43

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

LogEntry.php

2 lines

Diff 3356

View Options

Replace object return value by class typeClosedPublicActions