Differential D1370

Use UTC timezone to determine month heading title
ClosedPublic
Actions

Authored by dereckson on Mar 1 2018, 01:09.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 9, 16:47

	Unknown Object (File)
	Sat, Nov 9, 07:00

	Unknown Object (File)
	Sat, Nov 9, 06:00

	Unknown Object (File)
	Fri, Nov 8, 09:12

	Unknown Object (File)
	Fri, Nov 8, 09:12

	Unknown Object (File)
	Thu, Nov 7, 17:46

	Unknown Object (File)
	Sun, Nov 3, 07:24

	Unknown Object (File)
	Sun, Nov 3, 07:24

Subscribers

None

Details

Reviewers

Commits

rINFRAWWWa75d93ff8d09: Use UTC timezone to determine month heading title
rSERVERSLOGDESIGNa75d93ff8d09: Use UTC timezone to determine month heading title

Summary

The 2018-02-28 23:30 and 23:02 log entries are correctly considered
UTC by the JS code.

Yet, H2 month title uses local timezone, not UTC one. This triggers
a split of the title according browser local timezones:

for local timezones in UTC or UTC-n, the correct month February is printed
for local timezones in UTC+n, the +n 'March' is used instead.

This change fixes this bug asking the month in the UTC timezone.

Test Plan

Tested on https://infra.nasqueron.org/servers-log/

Diff Detail

Repository

rSERVERSLOGDESIGN Servers logs website (design)

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Mar 1 2018, 01:09

dereckson created this revision.

dereckson mentioned this in rSERVERSLOGDESIGNda626f59dd95: Parse servers logs from API.Mar 1 2018, 01:09

dereckson accepted this revision.Mar 1 2018, 01:12

This revision is now accepted and ready to land.Mar 1 2018, 01:12

Closed by commit rSERVERSLOGDESIGNa75d93ff8d09: Use UTC timezone to determine month heading title (authored by dereckson). · Explain WhyMar 1 2018, 01:12

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

assets/

js/

2 lines

Diff 3503

src/assets/js/app.js

Loading...