Page MenuHomeDevCentral

PSR-1 compatible tests
ClosedPublic

Authored by dereckson on Dec 31 2015, 18:58.
Referenced Files
Unknown Object (File)
Tue, Nov 12, 04:23
Unknown Object (File)
Tue, Nov 12, 02:42
Unknown Object (File)
Sun, Nov 10, 08:31
Unknown Object (File)
Sat, Nov 9, 15:11
Unknown Object (File)
Sat, Nov 9, 12:20
Unknown Object (File)
Sat, Nov 9, 11:44
Unknown Object (File)
Thu, Nov 7, 20:53
Unknown Object (File)
Thu, Nov 7, 20:37
Subscribers
None

Details

Reviewers
dereckson
Commits
Unknown Object (Diffusion Commit)
rNOTIFc624f02dffce: PSR-1 compatible tests
Summary

PHP Tests are now put in Nasqueron\Notifications\Tests namespace.

This allows to full PSR-1 compatibility both for app/ and tests/ directories.

Test Plan

Run phpunit.

Diff Detail

Repository
rNOTIF Notifications center
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
tests
Build Status
Buildable 173
Build 173: arc lint + arc unit

Event Timeline

dereckson retitled this revision from to PSR-1 compatible tests.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson edited edge metadata.
This revision is now accepted and ready to land.Dec 31 2015, 18:59
This revision was automatically updated to reflect the committed changes.

The goal of this change is to be able to run a minimalist phpcs --standard=PSR1 run.

In a coming change, we'll call phpcs from a Jenkins job using this target:

<target name="phpcs"
        unless="phpcs.done"
        description="Find coding standard violations using PHP_CodeSniffer and print human readable output. Intended for usage on the command line before committing.">
 <exec executable="${phpcs}" taskname="phpcs">
  <arg value="--standard=PSR1" />
  <arg value="--extensions=php" />
  <arg value="--ignore=autoload.php" />
  <arg path="${basedir}/app" />
  <arg path="${basedir}/tests" />
 </exec>

 <property name="phpcs.done" value="true"/>
</target>