Page MenuHomeDevCentral

Consolidate nginx installation and common config files
ClosedPublic

Authored by dereckson on Mar 13 2018, 01:16.

Details

Summary

Both shellserver and webserver-legacy roles contains states
useful for every server with nginx. Those states are moved to
the webserver-core role.

Let's encrypt certbot client doesn't need to be installed for
Docker engines, as it runs then as a container.

Test Plan
  • salt equatower state.apply roles/webserver-core (Docker, should provision)
  • salt eglide state.apply roles/webserver-core test=True (non Docker, should be no op)

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dereckson requested review of this revision.Mar 13 2018, 01:16
dereckson created this revision.
dereckson edited the summary of this revision. (Show Details)Mar 15 2018, 18:54
dereckson edited the test plan for this revision. (Show Details)Mar 15 2018, 20:45
dereckson updated this revision to Diff 3632.Mar 15 2018, 21:17

When it's not broken, don't fix it?

dereckson accepted this revision.Mar 15 2018, 21:19
$ salt equatower state.apply roles/webserver-core test=True
equatower:
----------
          ID: nginx
    Function: pkg.installed
      Result: None
     Comment: The following packages would be installed/updated: nginx
     Started: 02:19:08.583014
    Duration: 935.315 ms
     Changes:
----------
          ID: /usr/bin/list-nginx-vhosts-conf
    Function: file.managed
      Result: None
     Comment: The file /usr/bin/list-nginx-vhosts-conf is set to be changed
     Started: 02:19:09.521603
    Duration: 34.917 ms
     Changes:
----------
          ID: /usr/bin/autochmod
    Function: file.managed
      Result: None
     Comment: The file /usr/bin/autochmod is set to be changed
     Started: 02:19:09.556725
    Duration: 12.39 ms
     Changes:

Summary for equatower
------------
Succeeded: 3 (unchanged=3)
Failed:    0
------------
Total states run:     3
Total run time: 982.622 ms
This revision is now accepted and ready to land.Mar 15 2018, 21:19
dereckson updated this revision to Diff 3635.Mar 15 2018, 23:20

Install TCL too

dereckson accepted this revision.Mar 16 2018, 01:18
This revision was automatically updated to reflect the committed changes.