Differential D144

Fixed namespace issue
ClosedPublic
Actions

Authored by dereckson on Jan 1 2016, 00:04.

Details

Reviewers

dereckson

Commits

Unknown Object (Diffusion Commit)
rNOTIFdd075a696bcd: Fixed namespace issue

Summary

PhabricatorAPIException inherits from \RuntimeException,
not from Nasqueron\Notifications\Phabricator\RuntimeException.

This issue has been noticed running phpDox:

[phpdox] [31.12.2015 - 23:48:38] -
Nasqueron\Notifications\Phabricator\PhabricatorAPIException
(missing Nasqueron\Notifications\Phabricator\RuntimeException)

Test Plan

trivial

Diff Detail

Repository

rNOTIF Notifications center

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

RuntimeException

Build Status

Buildable 182
Build 182: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 344.Jan 1 2016, 00:04

dereckson retitled this revision from to Fixed namespace issue.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson accepted this revision.Jan 1 2016, 00:05

dereckson edited edge metadata.

This revision is now accepted and ready to land.Jan 1 2016, 00:05

Closed by commit rNOTIFdd075a696bcd: Fixed namespace issue (authored by dereckson, committed by dereckson). · Explain WhyJan 1 2016, 00:05

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

app/

Phabricator/

PhabricatorAPIException.php

2 lines

Diff 344

View Options

app/Phabricator/PhabricatorAPIException.php

Fixed namespace issueClosedPublicActions