Page MenuHomeDevCentral

Fixed namespace issue
ClosedPublic

Authored by dereckson on Jan 1 2016, 00:04.
Tags
None
Referenced Files
F9643766: D144.diff
Wed, Jun 11, 00:57
F9637010: D144.diff
Tue, Jun 10, 19:55
F9633303: D144.diff
Tue, Jun 10, 17:12
F9632889: D144.id345.diff
Tue, Jun 10, 17:00
F9629339: D144.diff
Tue, Jun 10, 14:26
F9624664: D144.diff
Tue, Jun 10, 11:24
Unknown Object (File)
Mon, Jun 9, 23:28
Unknown Object (File)
Mon, Jun 9, 20:46
Subscribers
None

Details

Reviewers
dereckson
Commits
Unknown Object (Diffusion Commit)
rNOTIFdd075a696bcd: Fixed namespace issue
Summary

PhabricatorAPIException inherits from \RuntimeException,
not from Nasqueron\Notifications\Phabricator\RuntimeException.

This issue has been noticed running phpDox:

[phpdox] [31.12.2015 - 23:48:38] -
Nasqueron\Notifications\Phabricator\PhabricatorAPIException
(missing Nasqueron\Notifications\Phabricator\RuntimeException)

Test Plan

trivial

Diff Detail

Repository
rNOTIF Notifications center
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
RuntimeException
Build Status
Buildable 182
Build 182: arc lint + arc unit

Event Timeline

dereckson retitled this revision from to Fixed namespace issue.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson edited edge metadata.
This revision is now accepted and ready to land.Jan 1 2016, 00:05
This revision was automatically updated to reflect the committed changes.