Don't load extension or skin when marked false
ClosedPublic
Actions

Authored by dereckson on Mar 22 2018, 23:41.

Tags

None

Referenced Files

	F3202915: D1475.id3781.diff
	Fri, Jun 28, 18:17

	F3202529: D1475.id3780.diff
	Fri, Jun 28, 18:08

	F3195500: D1475.id3781.diff
	Fri, Jun 28, 14:05

	F3195493: D1475.id3780.diff
	Fri, Jun 28, 14:05

	Unknown Object (File)
	Thu, Jun 27, 10:38

	Unknown Object (File)
	Thu, Jun 27, 00:26

	Unknown Object (File)
	Thu, Jun 27, 00:06

	Unknown Object (File)
	Mon, Jun 24, 23:49

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rSAASMW17d806c8e303: Don't load extension or skin when marked false

Summary

The saasUse{Type}{Name} setting is a boolean requiring to load
an extension or a skin.

The extension or skin was currently unconditionally loaded,
as the loader only checked the presence of the key, not its
value.

Test Plan

Tested with D1474

Diff Detail

Repository

rSAASMW SaaS MediaWiki

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

fix-extensions-load

Build Status

Buildable 2330
Build 2578: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Mar 22 2018, 23:41

dereckson created this revision.

Harbormaster completed remote builds in B2330: Diff 3780.Mar 22 2018, 23:41

dereckson accepted this revision.Mar 22 2018, 23:41

dereckson added a child revision: D1474: Enable WolfplexMessages on www.wolfplex.org.

This revision is now accepted and ready to land.Mar 22 2018, 23:42

Closed by commit rSAASMW17d806c8e303: Don't load extension or skin when marked false (authored by dereckson). · Explain WhyMar 22 2018, 23:44

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

Configuration.php

2 lines

Diff 3780

View Options

Don't load extension or skin when marked falseClosedPublicActions