Page MenuHomeDevCentral
Differential D1536

Enforce opening brace on same line than class declaration
ClosedPublic
Actions

Authored by dereckson on Mar 29 2018, 21:08.
Tags
None
Referenced Files
F3750203: D1536.diff
Sat, Nov 16, 22:26
F3747538: D1536.id3921.diff
Sat, Nov 16, 02:37
F3747537: D1536.id3920.diff
Sat, Nov 16, 02:37
F3747536: D1536.id3919.diff
Sat, Nov 16, 02:37
Unknown Object (File)
Tue, Nov 12, 21:04
Unknown Object (File)
Thu, Nov 7, 21:23
Unknown Object (File)
Thu, Oct 31, 13:01
Unknown Object (File)
Tue, Oct 22, 15:49
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rNOTIF85fc0f62b8e1: Enforce opening brace on same line than class declaration
Summary

Currently, Laravel files were sometimes left untouched.

Even if generated by Laravel, it seems better to apply Nasqueron
code style to those files too.

Test Plan

no op

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2410
Build 2658: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Mar 29 2018, 21:08
dereckson created this revision.
Harbormaster failed remote builds in B2409: Diff 3919!Mar 29 2018, 21:08
dereckson planned changes to this revision.Mar 29 2018, 21:09

Mixed with a composer version upgrade

dereckson edited the summary of this revision. (Show Details)Mar 29 2018, 21:10
dereckson edited the test plan for this revision. (Show Details)
dereckson updated this revision to Diff 3920.Mar 29 2018, 21:13

Restrict change to only the style fix

Harbormaster completed remote builds in B2410: Diff 3920.Mar 29 2018, 21:13
dereckson accepted this revision.Mar 29 2018, 21:13
This revision is now accepted and ready to land.Mar 29 2018, 21:13
Closed by commit rNOTIF85fc0f62b8e1: Enforce opening brace on same line than class declaration (authored by dereckson). · Explain WhyMar 29 2018, 21:15
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
app/
Console/
Commands/
4 lines
4 lines
Http/
Controllers/
4 lines
4 lines
Middleware/
4 lines
4 lines
Requests/
4 lines
Jobs/
4 lines
Providers/
4 lines
4 lines
4 lines
4 lines
4 lines

Diff 3920

View Options

app/Console/Commands/ConfigShow.php

Loading...
View Options

app/Console/Kernel.php

Loading...
View Options

app/Http/Controllers/Controller.php

Loading...
View Options

app/Http/Kernel.php

Loading...
View Options

app/Http/Middleware/EncryptCookies.php

Loading...
View Options

app/Http/Middleware/VerifyCsrfToken.php

Loading...
View Options

app/Http/Requests/Request.php

Loading...
View Options

app/Jobs/Job.php

Loading...
View Options

app/Providers/AppServiceProvider.php

Loading...
View Options

app/Providers/PhabricatorAPIServiceProvider.php

Loading...
View Options

app/Providers/PhabricatorProjectsMapServiceProvider.php

Loading...
View Options

app/Providers/RouteServiceProvider.php

Loading...
View Options

app/Providers/SentryServiceProvider.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator